Skip to content

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Mar 21, 2025

Description

This commit ensures that the GitHub workflows (minus anything documentation-related) and other files in .github are synced with the module template.

  • Add pull request template
  • Add compatibility test
  • Use checkout-and-setup action, avoid the use of actions/cache for publishing
  • Bump to action-create-release-pr v4
    • This may address a bug where if the changelog is updated fully before attempting to create an RC, the Create Pull Request workflow cannot be run. v1 is likely using an old version of @metamask/auto-changelog.
  • Bump to action-publish-release v3
  • Bump to action-npm-publish v5
  • Bump to action-security-code-scanner v1
  • Notify Slack when new release is ready for approval
  • Remove unused get-release-version step

References

Compare the changes in this commit with the .github directory in the module template.

@mcmire mcmire force-pushed the update-github-workflows branch from d6fb24e to a57984c Compare March 21, 2025 18:35
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@mcmire mcmire marked this pull request as ready for review March 21, 2025 18:54
@mcmire mcmire requested a review from a team as a code owner March 21, 2025 18:54
This commit ensures that the GitHub workflows ( anything
documentation-related) and other files in `.github` are synced with the
module template.

- Add pull request template
- Add compatibility test
- Use `checkout-and-setup` action, avoid the use of `actions/cache`
  for publishing
- Bump to `action-create-release-pr` v4
- Bump to `action-publish-release` v3
- Bump to `action-npm-publish` v5
- Bump to `action-security-code-scanner` v1
- Notify Slack when new release is ready for approval
- Remove unused `get-release-version` step
@mcmire mcmire force-pushed the update-github-workflows branch from a57984c to 2334232 Compare March 31, 2025 14:24
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 46a3b8b into main May 27, 2025
21 checks passed
@mcmire mcmire deleted the update-github-workflows branch May 27, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants