Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions .github/workflows/build-lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,29 +83,3 @@ jobs:
echo "Working tree dirty at end of job"
exit 1
fi

compatibility-test:
name: Compatibility test
needs: prepare
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v1
with:
is-high-risk-environment: false
node-version: ${{ matrix.node-version }}
- name: Install dependencies via Yarn
run: rm yarn.lock && YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn
- run: yarn test
- name: Restore lockfile
run: git restore yarn.lock
- name: Require clean working directory
shell: bash
run: |
if ! git diff --exit-code; then
echo "Working tree dirty at end of job"
exit 1
fi
25 changes: 25 additions & 0 deletions .github/workflows/compatibility-test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: Compatibility Test

on:
workflow_call:

jobs:
compatibility-test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
steps:
- uses: MetaMask/action-checkout-and-setup@v1
with:
is-high-risk-environment: false
node-version: ${{ matrix.node-version }}
- run: rm yarn.lock && YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn
- run: yarn test
- run: git restore yarn.lock
- shell: bash
run: |
if ! git diff --exit-code; then
echo "Working tree dirty at end of job"
exit 1
fi
5 changes: 5 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ jobs:
name: Build, lint, and test
uses: ./.github/workflows/build-lint-test.yml

compatibility-test:
name: Compatibility test
uses: ./.github/workflows/compatibility-test.yml
if: ${{ github.ref == 'refs/heads/main' }}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Compatibility Test Not Blocking Main Branch

The new compatibility-test job isn't listed as a dependency for all-jobs-completed. This means compatibility-test failures on the main branch won't block the overall workflow from succeeding, potentially allowing problematic releases.

Fix in Cursor Fix in Web

all-jobs-completed:
name: All jobs completed
runs-on: ubuntu-latest
Expand Down
Loading