Simplify and upgrade expected RpcService type #403
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `createFetchMiddleware` takes an `RpcService`, there is no need for it to take its old signature (`fetch`, `btoa`, `rpcUrl`, and `originHttpHeaderKey`), and there is no need for the old logic (as that has been integrated into `RpcService`).
The only change that affects this package is in 11.3.0, where some types were changed so that if they take a type parameter that `extends Json`, they default to `Json` itself. Because of our lint rules that forced some changes in this PR itself. There should be no backward-incompatible changes, however. `object` is deprecated, so we do need to adapt to that at some point, but we can address that in a future PR.
mcmire
force-pushed
the
simplify-rpc-service-type
branch
from
c7c864b to
96412cf
Compare
mcmire
changed the base branch from
remove-deprecated-fetch-signature
to
main
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
`createFetchMiddleware` needs to declare that it takes an `RpcService`, but it cannot get a type from `@metamask/network-controller` or else this would create a circular dependency. Currently this package contains a copy of `AbstractRpcService` from `@metamask/network-controller` 22.2.0, but there are a couple of problems: 1) this type is not compatible with the latest version of the package, and 2) we want to avoid further incompatibilities in the future. This PR changes the signature for `createFetchMiddleware` so that it requires a simplified version of `RpcService` — one that only contains a `request` method. It also upgrades the dev dependency on `@metamask/network-controller` to 24.1.0.
mcmire
force-pushed
the
simplify-rpc-service-type
branch
from
96412cf to
545b910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createFetchMiddlewareneeds to declare that it takes anRpcService, but it cannot get a type from@metamask/network-controlleror else this would create a circular dependency. Currently this package contains a copy ofAbstractRpcServicefrom@metamask/network-controller22.2.0, but there are a couple of problems: 1) this type is not compatible with the latest version of the package, and 2) we want to avoid further incompatibilities in the future.This PR changes the signature for
createFetchMiddlewareso that it requires a simplified version ofRpcService, that is, one that only contains arequestmethod. It also upgrades the dev dependency on@metamask/network-controllerto 24.1.0.