Skip to content

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Sep 9, 2025

This is a prerequisite for upgrading the copy of AbstractRpcService in this repo to match the newest version of @metamask/network-controller.

The only version of @metamask/utils that could affect this package is in 11.3.0, where some types were changed so that if they take a type parameter that extends Json, they default to Json itself. Because of our lint rules, that forced some changes in this PR itself. Regardless, these changes should be backwards-compatible.

Additionally, we are using object from @metamask/utils and that is now deprecated, so we do need to adapt to that at some point. But we can address that in a future PR.

Copy link

socket-security bot commented Sep 9, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​types/​lodash@​4.17.201001007883100
Updated@​metamask/​utils@​11.1.0 ⏵ 11.7.09910093 +196 +4100

View full report

The only change that affects this package is in 11.3.0, where some types
were changed so that if they take a type parameter that `extends Json`,
they default to `Json` itself. Because of our lint rules that forced
some changes in this PR itself. There should be no backward-incompatible
changes, however.

`object` is deprecated, so we do need to adapt to that at some point,
but we can address that in a future PR.
@mcmire mcmire marked this pull request as ready for review September 10, 2025 13:35
@mcmire mcmire requested review from a team as code owners September 10, 2025 13:35
Mrtenz
Mrtenz previously approved these changes Sep 10, 2025
@mcmire mcmire requested a review from a team as a code owner September 10, 2025 16:33
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit badb634 into main Sep 10, 2025
20 checks passed
@mcmire mcmire deleted the bump-utils branch September 10, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants