-
-
Notifications
You must be signed in to change notification settings - Fork 5
chore: initial upgrade of storybook and react native #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. It is recommended to resolve "Warn" alerts too. Learn more about Socket for GitHub.
|
793a046
to
493ddde
Compare
📖 Storybook Preview |
// Only use FontLoader in native environment | ||
if (Platform.OS !== 'web') { | ||
return ( | ||
<ThemeProvider theme={Theme.Default} colorSet={ColorSet.Brand}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove color set and use useColorScheme hook from react native
@@ -2,7 +2,11 @@ import React, { useEffect, useState } from 'react'; | |||
import { ActivityIndicator } from 'react-native'; | |||
import * as Font from 'expo-font'; | |||
|
|||
const FontLoader = ({ children }) => { | |||
interface FontLoaderProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use type here
📖 Storybook Preview |
c470d0e
to
fcdf533
Compare
fcdf533
to
58f2edc
Compare
📖 Storybook Preview |
📖 Storybook Preview |
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist