Skip to content

Conversation

m4sterbunny
Copy link
Contributor

Description

Fixes #1501

Issue(s) fixed

Fixes #

Preview

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@m4sterbunny m4sterbunny requested a review from a team as a code owner August 26, 2024 11:00
Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 7:48am

Comment on lines 19 to 34
- For calls that require gas, topup your funds.

:::note Get testnet ETH

Topup your [MetaMask](https://metamask.io/) wallet from one of the following faucets to obtain Linea Sepolia ETH:

- [Infura faucet](https://www.infura.io/faucet/linea)
- [Covalent faucet](https://www.covalenthq.com/faucet/)

Alternatively, you can obtain [Sepolia ETH](https://www.infura.io/faucet/sepolia) and
[bridge](https://bridge.linea.build/) to the Linea Sepolia testnet.

See the [official Linea documentation](https://docs.linea.build/developers/guides/bridge) for
information about additional faucets and bridging funds.

:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- For calls that require gas, topup your funds.
:::note Get testnet ETH
Topup your [MetaMask](https://metamask.io/) wallet from one of the following faucets to obtain Linea Sepolia ETH:
- [Infura faucet](https://www.infura.io/faucet/linea)
- [Covalent faucet](https://www.covalenthq.com/faucet/)
Alternatively, you can obtain [Sepolia ETH](https://www.infura.io/faucet/sepolia) and
[bridge](https://bridge.linea.build/) to the Linea Sepolia testnet.
See the [official Linea documentation](https://docs.linea.build/developers/guides/bridge) for
information about additional faucets and bridging funds.
:::
- For calls that require gas, topup your funds.

This is not required in the MetaMask docs, since we now have a how-to page on testnet tokens, and most MM developers are more aware of how to acquire testnet funds.

@@ -15,7 +15,23 @@ Don't have an Infura account? Sign up for our free plan and start using the Line

## Prerequisites

Ensure you have an [API key](../../../../developer-tools/dashboard/get-started/create-api/) with the Linea network enabled.
- Ensure you have an [API key](../../../../developer-tools/dashboard/get-started/create-api/) with the Linea network enabled.
- For calls that require gas, topup your funds.
Copy link
Contributor

@joaniekube joaniekube Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'top up' I think, instead of popup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested to remove this completely in my comment. But if we were to keep this, even "top up" is a bit unclear – it should be something like "For calls that require gas, make sure you have enough funds."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there was no clear mapping Infura:MM for this one. IMO this is not the place, rather -- I think there should be a link to the "Get testnet ETH and tokens" page from the index page's "See also" forEach service --> let me know if I should raise issue for that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not high priority, but that's fine ^

@m4sterbunny m4sterbunny mentioned this pull request Aug 27, 2024
7 tasks
@alexandratran alexandratran merged commit d44007d into main Sep 4, 2024
9 checks passed
@alexandratran alexandratran deleted the 1501-link-fix branch September 4, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply link fixes if required
3 participants