Skip to content

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Nov 6, 2024

Description

First pass at addressing Vale issues.
Some false positives will be quieted in the GHA repo: Consensys/github-actions#65

Preview

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 2:27am

@alexandratran alexandratran marked this pull request as ready for review November 7, 2024 02:25
@alexandratran alexandratran requested review from a team as code owners November 7, 2024 02:25
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexandratran alexandratran merged commit fb0ec80 into main Nov 7, 2024
14 of 18 checks passed
@alexandratran alexandratran deleted the vale-fixes branch November 7, 2024 04:24
bgravenorst pushed a commit that referenced this pull request Nov 7, 2024
* Vale fixes

* edits

* edits

* edits
@alexandratran alexandratran mentioned this pull request Nov 12, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants