-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Delegation Toolkit] Adds tutorial #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited the tutorial for clarity and also made edits to other signing content for clarity and consistency.
I just have one main question: In the tutorial, we assume that user has already created and deployed a smart account as a prerequisite, but we also include a step to create a smart account. Should we either remove it from the prerequisites or remove it as a step?
It's correct, so prerequisite is creating and deploying a smart account, where as in step 3, we are again accessing the same account so we can register the passkey. As the call data needs to be signed by the smart account, and sent to smart account address, that step is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Adds a new tutorial: Use passkey as backup signer
Issue(s) fixed
Fixes #2210
Preview
https://metamask-docs-7w1b20o5s-consensys-ddffed67.vercel.app/delegation-toolkit/development/tutorials/use-passkey-as-backup-signer/
Checklist
Complete this checklist before merging your PR: