-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Delegation Toolkit Add ERC-20 paymaster tutorial #2259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some edits for clarity. One remaining question, otherwise lgtm.
Any reason we removed the Circle faucet? On testnet, there are lot of ERC-20 USDC tokens, and not having correct one would fail the user operation. Moreover, developers might not know where to get USDC faucet. |
# Conflicts: # src/pages/tutorials/create-custom-caveat-enforcer.md # src/pages/tutorials/use-erc20-paymaster.md # src/pages/tutorials/use-passkey-as-backup-signer.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added back link to the Circle faucet, and also changed the sidebar format to manually generated so we can link to the global tutorials from the DTK section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Adds a new tutorial on ERC-20 paymaster
Issue(s) fixed
Fixes #2244
Fixes #2263
Preview
https://metamask-docs-8f3pnt8qn-consensys-ddffed67.vercel.app/delegation-toolkit/development/tutorials/use-erc20-paymaster/
Checklist
Complete this checklist before merging your PR: