[Delegation Toolkit][v0.13] Update creating delegation references #2282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Minor DTK fixes * Apply suggestions from code review Co-authored-by: Ayush Bherwani <ayush.bherwani1998@gmail.com> --------- Co-authored-by: Ayush Bherwani <ayush.bherwani1998@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexandratran
approved these changes
Sep 8, 2025
delegation-toolkit/guides/delegation/execute-on-smart-accounts-behalf.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexandra Carrillo <12214231+alexandratran@users.noreply.github.com>
alexandratran
approved these changes
Sep 8, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -32,6 +32,7 @@ const delegation = createDelegation({ | |||
| }, | |||
| to: delegateAccount, | |||
| from: delegatorAccount, | |||
| environment: delegatorAccount.environment, | |||
There was a problem hiding this comment.
Bug: Incorrect Smart Account Property Access
The createDelegation examples incorrectly access delegatorAccount.environment. The environment property is specific to smart accounts, but delegatorAccount is typically an EOA and lacks this property. This pattern appears in several scope examples throughout the guides.
Additional Locations (2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue(s) fixed
Fixes #2242
Preview
Checklist