chore: Bump Snaps packages #37971
Merged
chore: Bump Snaps packages #37971
+108
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
✨ Files requiring CODEOWNER review ✨🫰 @MetaMask/core-platform (5 files, +77 -4)
🧩 @MetaMask/extension-devs (5 files, +10 -5)
📜 @MetaMask/policy-reviewers (5 files, +10 -5)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (5 files, +10 -5)
|
Member
Author
|
@metamaskbot update-policies |
Collaborator
Builds ready [bd56653]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [38550f0]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [459e650]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
FrederikBolding
force-pushed
the
fb/snaps-bump-v133
branch
from
459e650 to
312ec52
Compare
Collaborator
Builds ready [312ec52]
UI Startup Metrics (1258 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| initMessenger.subscribe('OnboardingController:stateChange', listener); | ||
|
|
||
| await promise; | ||
| } |
There was a problem hiding this comment.
Bug: Event listener not unsubscribed on error paths
In ensureOnboardingComplete, the OnboardingController:stateChange listener is only unsubscribed when completedOnboarding becomes true. If the promise is rejected, cancelled, or the await is interrupted, the listener remains subscribed indefinitely, causing a memory leak and continued event processing. The listener should be properly cleaned up in all execution paths, such as using a try-finally block or similar error handling mechanism.
Member
Author
There was a problem hiding this comment.
We control the promise, so it will only ever resolve.
| initMessenger.subscribe('OnboardingController:stateChange', listener); | ||
|
|
||
| await promise; | ||
| } |
There was a problem hiding this comment.
Bug: Race condition causes hanging if onboarding completes before listener subscribes
In ensureOnboardingComplete, there's a window between checking completedOnboarding state (line 103) and subscribing to the event listener (line 120). If onboarding completes during this window and no further state changes occur, the promise will hang indefinitely because the listener only resolves on future state changes. The function should re-check the state after subscribing or use a mechanism that handles already-completed onboarding.
Member
Author
There was a problem hiding this comment.
I'm assuming that onboarding cannot happen while the controllers are initializing so this is a moot point
Collaborator
Builds ready [1c642df]
UI Startup Metrics (1215 ± 92 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [6503485]
UI Startup Metrics (1229 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Mrtenz
requested changes
Nov 19, 2025
Member
Mrtenz
left a comment
Mrtenz
left a comment
There was a problem hiding this comment.
Cursor has some comments that seem worth addressing.
Mrtenz
previously approved these changes
Nov 19, 2025
FrederikBolding
force-pushed
the
fb/snaps-bump-v133
branch
from
6503485 to
62f9d5b
Compare
Member
Author
|
@metamaskbot update-policies |
Collaborator
|
No policy changes |
GuillaumeRx
approved these changes
Nov 20, 2025
Collaborator
Builds ready [62f9d5b]
UI Startup Metrics (1249 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Mrtenz
approved these changes
Nov 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.11.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bumps Snaps packages to the latest version. Notable changes include:
snap_setStateoperationsclientVersionsin the registryChangelog
CHANGELOG entry: Fixed a rare issue where Snaps updating state rapidly would lose data
Note
Bumps Snaps packages, requires onboarding completion before Snap operations, and passes extension client version to the Snaps registry; updates messengers, tests, and LavaMoat policy.
OnboardingController:getStateand subscribe toOnboardingController:stateChangeinSnapControllerInitmessenger.ensureOnboardingCompletetoSnapController.clientConfigwith{ type: 'extension', version }, parsingMETAMASK_VERSIONto strip prerelease tags.@metamask/snaps-controllersto^17.0.0and@metamask/snaps-rpc-methodsto^14.1.1(lockfile updates incl.@metamask/snaps-registry@^3.3.0).@metamask/eth-qr-keyring>async-mutexunder@metamask/snaps-rpc-methods.ensureOnboardingCompletewiring andclientConfig.versionbehavior.Written by Cursor Bugbot for commit 62f9d5b. This will update automatically on new commits. Configure here.