fix: tracks insufficient balance correctly for nonevm #37988
Merged
+51
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨🔄 @MetaMask/swaps-engineers (3 files, +51 -15)
|
Collaborator
Builds ready [500d78e]
UI Startup Metrics (1225 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [c4a5908]
UI Startup Metrics (1537 ± 143 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [1b120d9]
UI Startup Metrics (1223 ± 106 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
SteP-n-s
approved these changes
Nov 19, 2025
micaelae
reviewed
Nov 20, 2025
| insufficientBal: providerConfig?.rpcUrl?.includes('localhost') | ||
| ? true | ||
| : undefined, | ||
| : insufficientBalOverride, |
Member
There was a problem hiding this comment.
Suggested change
| : insufficientBalOverride, | |
| : isInsufficientBalance, |
Can you reuse the isInsufficientBalance value returned by the getValidationErrors selector instead? It's the same condition used for showing balance validation errors
Contributor
Author
There was a problem hiding this comment.
I think isInsufficientBalance is from the previous quote request, so it's always going to be behind a little, whereas these changes do it 'live' so the flag is always up to date
micaelae
reviewed
Nov 20, 2025
| providerConfig?.rpcUrl, | ||
| gasIncluded, | ||
| gasIncluded7702, | ||
| insufficientBalOverride, |
Member
There was a problem hiding this comment.
Suggested change
| insufficientBalOverride, | |
| isInsufficientBalance, |
micaelae
approved these changes
Nov 20, 2025
ghgoodreau
deleted the
SWAPS-3470-insufficient-bal-tracking-for-nonevm
branch
metamaskbot
added
the
release-13.11.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tracking for insufficientBalance correctly for nonEVM chains.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Computes insufficient balance for non-EVM chains using on-chain balance and sanitized input, and centralizes amount sanitization with safer amount calculations.
insufficientBalOverridefor non-EVM chains usingfromTokenBalanceandBigNumber, passed toupdateBridgeQuoteRequestParams.safeAmountForCalc(fromAmount)when derivingsrcTokenAmountto avoid invalid/partial inputs.sanitizeAmountInputandsafeAmountForCalcinui/pages/bridge/utils/quote.ts.bridge-input-group.tsxnow imports and uses sharedsanitizeAmountInput; removes local sanitizer.Written by Cursor Bugbot for commit 1b120d9. This will update automatically on new commits. Configure here.