Skip to content

Conversation

@rarquevaux
Copy link
Contributor

@rarquevaux rarquevaux commented Jan 28, 2026

Add client to metadata for smartTransactions and relayTransactions

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry: add client to metadata for smartTransactions and relayTransactions

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches transaction submission payloads sent to Smart Transactions and relay services; while additive, it can affect downstream API validation/analytics expectations if mismatched with backend/controller versions.

Overview
Smart Transaction submissions now include an additional metadata.client field alongside txType for batch, pre-signed, and fee-signed flows.

EIP-7702 relay submissions (delegation-7702-publish) also attach the same client identifier, derived from platform (Firefox vs Chrome) via a new smart-transaction/utils.ts helper and new shared constants. The PR also upgrades @metamask/smart-transactions-controller to ^22.3.0.

Written by Cursor Bugbot for commit 4329580. This will update automatically on new commits. Configure here.

@rarquevaux rarquevaux requested a review from a team as a code owner January 28, 2026 18:22
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-transactions Transactions team label Jan 28, 2026
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​smart-transactions-controller@​22.1.0 ⏵ 22.3.097 +1100100 +197 +550

View full report

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 28, 2026

✨ Files requiring CODEOWNER review ✨

💸 @MetaMask/transactions (2 files, +24 -3)
  • 📁 app/
    • 📁 scripts/
      • 📁 lib/
        • 📁 smart-transaction/
          • 📄 smart-transactions.ts +13 -3
          • 📄 utils.ts +11 -0

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Jan 28, 2026

Builds ready [4329580]
UI Startup Metrics (1309 ± 121 ms)
PlatformBuildTypePageMetricTest Title (ms)Persona (ms)Mean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--13091064173312113711482
load--1118891151811211761274
domContentLoaded--1111887151011211691268
domInteractive--251685162372
firstPaint--152641343137193286
backgroundConnect--23121030813236257
firstReactRender--17104052030
initialActions--107113
loadScripts--89567912891119551058
setupStore--1455061724
numNetworkReqs--211579171572
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--20081582279824921412502
load--1076955156913210831451
domContentLoaded--1062945155913310711445
domInteractive--37192242837105
firstPaint--189711572162237356
backgroundConnect--33128163164328495
firstReactRender--24164572741
initialActions--105112
loadScripts--82572213051278311192
setupStore--1774881938
numNetworkReqs--1254925954146243
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--87969311831109791050
load--7325971104100797921
domContentLoaded--726593109799793915
domInteractive--261778152469
firstPaint--1086231451128208
backgroundConnect--41191562741107
firstReactRender--15103651629
initialActions--104111
loadScripts--722591109598791913
setupStore--1262941321
numNetworkReqs--221584181574
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--1274890197421114711614
load--71860711641157301012
domContentLoaded--70860311581157161008
domInteractive--36181843034112
firstPaint--1466450392175350
backgroundConnect--16813356887158516
firstReactRender--22173432429
initialActions--101011
loadScripts--7066011149113714999
setupStore--1242131318
numNetworkReqs--1285326358159252
19--------
FirefoxBrowserifyStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--14591175205719315641956
load--1162994183113612301396
domContentLoaded--1162994183113612291396
domInteractive--74332704893188
firstPaint--------
backgroundConnect--68262494886188
firstReactRender--1394651321
initialActions--103122
loadScripts--1125980171312211751364
setupStore--144120171145
numNetworkReqs--231284181876
19--------
BrowserifyPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--28601954976398028674646
load--14321052812778313552748
domContentLoaded--14321052812778313542748
domInteractive--215386178626122822
firstPaint--------
backgroundConnect--3301171819320272957
firstReactRender--21153142429
initialActions--213123
loadScripts--13891030809976713202659
setupStore--1817809222277664
numNetworkReqs--70351854294180
19--------
WebpackStandard Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--16051233217418317231933
load--13851158194014914831644
domContentLoaded--13841158194014914831644
domInteractive--782719039106143
firstPaint--------
backgroundConnect--70252264883179
firstReactRender--13102631420
initialActions--103112
loadScripts--13451121182113014371573
setupStore--1652192812100
numNetworkReqs--231284181877
19--------
WebpackPower User Home0--------
1--------
2--------
3--------
4--------
5--------
6--------
7--------
8--------
9--------
10--------
11--------
12--------
13--------
14--------
15--------
16--------
17--------
18--------
uiStartup--30711993740189937804556
load--17211225589566517783002
domContentLoaded--17201225589566517783001
domInteractive--953384291103217
firstPaint--------
backgroundConnect--3471041767334340992
firstReactRender--22164352632
initialActions--206122
loadScripts--16571207586564016872974
setupStore--1738767231320719
numNetworkReqs--68371873983174
19--------
📊 Page Load Benchmark Results

Current Commit: 4329580 | Date: 1/28/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±69ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 729ms (±68ms) 🟢 | historical mean value: 720ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 76ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 69ms 1.00s 1.30s 1.24s 1.30s
domContentLoaded 729ms 68ms 694ms 994ms 930ms 994ms
firstPaint 76ms 10ms 56ms 148ms 88ms 148ms
firstContentfulPaint 76ms 10ms 56ms 148ms 88ms 148ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 994 Bytes (0.02%)
  • ui: 2 Bytes (0%)
  • common: 725 Bytes (0.01%)

@rarquevaux rarquevaux enabled auto-merge January 28, 2026 19:54
@rarquevaux rarquevaux added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main with commit 23c4e4d Jan 29, 2026
350 of 353 checks passed
@rarquevaux rarquevaux deleted the feat/STX-mm-send-client branch January 29, 2026 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2026
@metamaskbot metamaskbot added the release-13.17.0 Issue or pull request that will be included in release 13.17.0 label Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.17.0 Issue or pull request that will be included in release 13.17.0 size-S team-transactions Transactions team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants