-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat(analytics): add client to metadata for smartTransactions and relayTransactions #39612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+36
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
✨ Files requiring CODEOWNER review ✨💸 @MetaMask/transactions (2 files, +24 -3)
|
Contributor
Builds ready [4329580]
UI Startup Metrics (1309 ± 121 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
nthpool
approved these changes
Jan 28, 2026
klejeune
approved these changes
Jan 29, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-13.17.0
Issue or pull request that will be included in release 13.17.0
size-S
team-transactions
Transactions team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add client to metadata for smartTransactions and relayTransactions
Description
Changelog
CHANGELOG entry: add client to metadata for smartTransactions and relayTransactions
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches transaction submission payloads sent to Smart Transactions and relay services; while additive, it can affect downstream API validation/analytics expectations if mismatched with backend/controller versions.
Overview
Smart Transaction submissions now include an additional
metadata.clientfield alongsidetxTypefor batch, pre-signed, and fee-signed flows.EIP-7702 relay submissions (
delegation-7702-publish) also attach the sameclientidentifier, derived from platform (Firefox vs Chrome) via a newsmart-transaction/utils.tshelper and new shared constants. The PR also upgrades@metamask/smart-transactions-controllerto^22.3.0.Written by Cursor Bugbot for commit 4329580. This will update automatically on new commits. Configure here.