Skip to content

feat: Use chainId when checking if it's a smart transaction #14890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 30, 2025
Merged

feat: Use chainId when checking if it's a smart transaction #14890

merged 16 commits into from
Apr 30, 2025
+193 −59

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Apr 25, 2025 •
edited
Loading

Description

We should be using a chainId param from a transaction (if available) to better support multichain efforts. This PR also disables unused STX networks in the dev environment and is similar to the PR in the extension: MetaMask/metamask-extension#32201

Related issues

Fixes:

Manual testing steps

  1. Make sure that smart transactions still work (Send, Swap, dapp transactions)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added the team-transactions Transactions team label Apr 25, 2025
@dan437 dan437 requested review from a team as code owners April 25, 2025 12:46
@dan437 dan437 marked this pull request as draft April 25, 2025 12:46
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 force-pushed the stx-multichain branch 3 times, most recently from cc00c68 to a965302 Compare April 29, 2025 12:06
@dan437 dan437 marked this pull request as ready for review April 29, 2025 12:15
@dan437 dan437 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6dc267c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd9d9417-345a-4db7-aa17-9f966f0f1d66

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 29, 2025
dan437 added 10 commits April 30, 2025 13:11
@dan437
Use chainId as a second param for selectShouldUseSmartTransaction
6ab52e5 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Use chainId when calling shouldUseSmartTransaction
e0ecf8c 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Always pass a chainId into the shouldUseSmartTransaction selector
93a5618 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Use a globalChainId if transaction.chainId is not there on the Send C…
2828100 
…onfirmation page

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

# Conflicts:
#	app/components/Views/confirmations/legacy/SendFlow/Confirm/index.js
@dan437
Update the RPC URL check for STX
6237f6b 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Enable feature flag check for STX
29db0c1 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Update linting
2bda69c 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Fix linting
add8efc 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Update a test
7b7f48f 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Resolve linting issues
b51a871 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
dan437 added 6 commits April 30, 2025 13:11
@dan437
Linting
f8b2b4a 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Disable unused networks for STX
8649c2e 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Add back the check for STX liveness
f90422a 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Update tests, refactoring
0b1588f
@dan437
Remove comments
108ffa0 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@dan437
Resolve linting, remove a comment
e5b3856 
Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
2.4% Duplication on New Code

See analysis details on SonarQube Cloud

@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 30, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e5b3856
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/11ecdae6-f601-4238-87a5-c8fc928b962a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dan437 dan437 added the QA Passed A successful QA run through has been done label Apr 30, 2025
EtherWizard33
EtherWizard33 approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dan437, great stuff, thanks for this PR and your support on this so far!
LGTM, approved :)

@dan437 dan437 added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit 57a9981 Apr 30, 2025
49 of 55 checks passed
@dan437 dan437 deleted the stx-multichain branch April 30, 2025 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klejeune klejeune klejeune approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@nthpool nthpool nthpool approved these changes

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.47.0 Issue or pull request that will be included in release 7.47.0 Remove GNS Run Smoke E2E Triggers smoke e2e on Bitrise team-transactions Transactions team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dan437 @klejeune @pedronfigueiredo @nthpool @EtherWizard33 @hesterbruikman @metamaskbot