Skip to content

fix: cp-7.46.0 fix solana token list render #14898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 28, 2025

Conversation

sahar-fehri
Copy link
Contributor

Description

PR to fix token list render after account creation

Related issues

Fixes:

Manual testing steps

  1. Create a first solana account
  2. Create a second account
  3. You should see your tokens without having to switch accounts

Screenshots/Recordings

Before

Screen.Recording.2025-04-25.at.19.48.13.mov

After

Screen.Recording.2025-04-25.at.19.46.09.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested review from a team as code owners April 25, 2025 17:49
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri changed the title fix: fix solana token list render fix: cp-7.46.0 fix solana token list render Apr 25, 2025
@sahar-fehri sahar-fehri added the Run Smoke E2E Requires smoke E2E testing label Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4a5a3f5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0ddbdf23-5c0d-49a3-ba1d-3fb089d9e8f4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri force-pushed the fix/fix-render-asset-list-on-account-creation branch from 5bc356e to 5fc1164 Compare April 25, 2025 18:00
gambinish
gambinish previously approved these changes Apr 25, 2025
Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tested on iOS. Bitrise is failing though.

Would just want to make sure we get Swaps approval here in case this selector removal effects their code as well.

@sahar-fehri sahar-fehri added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5fc1164
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3447cb29-a36a-40b6-9f89-73119f6201f3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f89efa6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fd3676b1-1219-444c-bee8-84089ff22e3a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@infiniteflower infiniteflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's still working for Bridge, approved!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.81%. Comparing base (944fce2) to head (e413f4d).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14898      +/-   ##
==========================================
+ Coverage   67.71%   67.81%   +0.10%     
==========================================
  Files        2329     2342      +13     
  Lines       50144    50367     +223     
  Branches     7373     7423      +50     
==========================================
+ Hits        33954    34158     +204     
- Misses      14054    14058       +4     
- Partials     2136     2151      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sahar-fehri sahar-fehri added the no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 25, 2025
@sahar-fehri sahar-fehri added the No QA Needed Apply this label when your PR does not need any QA effort. label Apr 26, 2025
@sahar-fehri sahar-fehri added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit 8f22725 Apr 28, 2025
43 of 44 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-render-asset-list-on-account-creation branch April 28, 2025 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.47.0 Issue or pull request that will be included in release 7.47.0 Run Smoke E2E Requires smoke E2E testing team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants