Skip to content

Conversation

runway-github[bot]
Copy link
Contributor

@runway-github runway-github bot commented Aug 8, 2025

Description

Fixes an issue where the native token balances were not updating.

Also updated the AccountTrackerController.refresh calls we make.

The controller patch will be removed once this core package change is
released
MetaMask/core#6250

Changelog

CHANGELOG entry: fix: native token balance updates and optimise
controller calls

Related issues

Fixes: #17958

Manual testing steps

Please test native token transfers.

  1. On extension, send tokens between accounts
  2. On mobile, do you see the native token update after <3 min? Does the
    "swipe to refresh" update the native token?

Screenshots/Recordings

Before

https://www.loom.com/share/4e09abee586a46bfb584b9ae5adfc7c2?sid=1596d3dc-7e5a-4552-8ac2-bd1c6d9b7420

After

https://www.loom.com/share/f17e067b35d74e71a1002bf177844b8f?sid=72499fc2-a31a-4cc9-b9db-5fd500343a5c

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. 0ec2d2e

…s and optimise controller calls (#18092)

## **Description**

Fixes an issue where the native token balances were not updating.

Also updated the `AccountTrackerController.refresh` calls we make.

The controller patch will be removed once this core package change is
released
MetaMask/core#6250

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: fix: native token balance updates and optimise
controller calls

## **Related issues**

Fixes: #17958

## **Manual testing steps**

Please test native token transfers.

1. On extension, send tokens between accounts
2. On mobile, do you see the native token update after <3 min? Does the
"swipe to refresh" update the native token?

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->


https://www.loom.com/share/4e09abee586a46bfb584b9ae5adfc7c2?sid=1596d3dc-7e5a-4552-8ac2-bd1c6d9b7420

### **After**


https://www.loom.com/share/f17e067b35d74e71a1002bf177844b8f?sid=72499fc2-a31a-4cc9-b9db-5fd500343a5c

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github bot requested a review from a team as a code owner August 8, 2025 12:59
@runway-github runway-github bot requested a review from a team August 8, 2025 12:59
Copy link
Contributor

github-actions bot commented Aug 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarqubecloud bot commented Aug 8, 2025

@NicolasMassart NicolasMassart merged commit 8cc5036 into release/7.53.0 Aug 8, 2025
63 of 65 checks passed
@NicolasMassart NicolasMassart deleted the runway-cherry-pick-7.53.0-1754657938 branch August 8, 2025 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Aug 8, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.53.0 on PR, as PR was cherry-picked in branch 7.53.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.53.0 Issue or pull request that will be included in release 7.53.0 team-runway-bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants