Address PR comments

Author: FrederikBolding

packages/snaps-sdk/src/internals/structs.test.ts

@@ -69,14 +69,6 @@ describe('typedUnion', () => {
     BoxStruct,
     typedUnion([TextStruct, FieldStruct]),
   ]);
-  const stringUnion = nullUnion([
-    string(),
-    typedUnion([TextStruct, BoldStruct]),
-  ]);
-  const nonTypedObjectUnion = nullUnion([
-    typedUnion([TextStruct, BoldStruct]),
-    object({ type: literal('bar') }),
-  ]);
 
   it('validates strictly the part of the union that matches the type', () => {
     // @ts-expect-error Invalid props.
@@ -97,6 +89,11 @@ describe('typedUnion', () => {
   });
 
   it('validates when nested in a union including primitives', () => {
+    const stringUnion = nullUnion([
+      string(),
+      typedUnion([TextStruct, BoldStruct]),
+    ]);
+
     // @ts-expect-error Invalid props.
     const result = validate(Text({}), stringUnion);
 
@@ -106,6 +103,11 @@ describe('typedUnion', () => {
   });
 
   it('validates when nested in a union including non-typed objects', () => {
+    const nonTypedObjectUnion = nullUnion([
+      typedUnion([TextStruct, BoldStruct]),
+      object({ type: literal('bar') }),
+    ]);
+
     const result = validate({ type: 'abc' }, nonTypedObjectUnion);
 
     expect(result[0]?.message).toBe(

packages/snaps-sdk/src/jsx/validation.ts

@@ -620,7 +620,7 @@ export const BoldStruct: Describe<BoldElement> = element('Bold', {
         return string();
       }
       // eslint-disable-next-line @typescript-eslint/no-use-before-define
-      return lazy(() => ItalicStruct) as unknown as Struct<
+      return ItalicStruct as unknown as Struct<
         SnapElement<JsonObject, 'Italic'>
       >;
     }),
@@ -637,9 +637,7 @@ export const ItalicStruct: Describe<ItalicElement> = element('Italic', {
         return string();
       }
 
-      return lazy(() => BoldStruct) as unknown as Struct<
-        SnapElement<JsonObject, 'Bold'>
-      >;
+      return BoldStruct as unknown as Struct<SnapElement<JsonObject, 'Bold'>>;
     }),
   ]),
 });