feat: Add new metadata to snaps controllers #3632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new metadata properties `includeInStateLogs` and `usedInUi` have been added to all snaps controllers. Relates to https://github.com/MetaMask/decisions/blob/main/decisions/core/0014-Expand-Controller-Metadata.md
Gudahtt
force-pushed
the
add-new-controller-metadata
branch
from
f027323 to
19b08a7
Compare
Gudahtt
commented
Sep 8, 2025
| @@ -82,40 +82,6 @@ describe('SnapInterfaceController', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('constructor', () => { | |||
| it('persists notification interfaces', () => { | |||
There was a problem hiding this comment.
This was moved below to the metadata describe block, as it seemed like a better fit there.
Gudahtt
commented
Sep 8, 2025
| @@ -305,80 +309,6 @@ describe('SnapController', () => { | |||
| snapController.destroy(); | |||
| }); | |||
|
|
|||
| it('can rehydrate state', async () => { | |||
There was a problem hiding this comment.
These tests were moved to the metadata block as well
Gudahtt
commented
Sep 8, 2025
| `); | ||
| }); | ||
|
|
||
| it('strips out large state properties', () => { |
There was a problem hiding this comment.
This is a new test I wrote to ensure the new state deriver is working as expected
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3632 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 417 417
Lines 11803 11811 +8
Branches 1844 1844
=======================================
+ Hits 11601 11609 +8
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcmire
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
Probably need a review from @Mrtenz or @GuillaumeRx, but LGTM at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new metadata properties
includeInStateLogsandusedInUihave been added to all snaps controllers.Relates to https://github.com/MetaMask/decisions/blob/main/decisions/core/0014-Expand-Controller-Metadata.md