Fix compatibility with Feather Client

[IHaxU]

Type of change

• Bug fix
• New feature

Description

This modifies ChatHudMixin to ensure compatibility between Meteor Client and Feather client. Using @Local in mixins targeting the addVisibleMessage method causes crashes when used alongside Feather. This change removes the use of @Local, instead manually reconstructing the necessary variables to maintain the same functionality.

Related issues

Mention any issues that this pr relates to.

How Has This Been Tested?

2025-05-30.03-01-15.mp4

Checklist:

• My code follows the style guidelines of this project.
• I have added comments to my code in more complex areas.
• I have tested the code in both development and production environments.

[machiecodes]

I'm opening 3 PRs this week to break feather client more

[RacoonDog]

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

[IHaxU]

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

Could you elaborate on this? I duplicated vanilla logic cause onBreakChatMessageLines used a @Local (@Local List<OrderedText> list)

[RacoonDog]

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

Could you elaborate on this? I duplicated vanilla logic cause onBreakChatMessageLines used a @Local (@Local List<OrderedText> list)

target @At(value = "INVOKE", target = "Ljava/util/List;add(ILjava/lang/Object;)V", remap = false) and capture the argument, this would get the same value as what the @Local that was breaking compat had

[IHaxU]

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

Could you elaborate on this? I duplicated vanilla logic cause onBreakChatMessageLines used a @Local (@Local List<OrderedText> list)

target @At(value = "INVOKE", target = "Ljava/util/List;add(ILjava/lang/Object;)V", remap = false) and capture the argument, this would get the same value as what the @Local that was breaking compat had

I believe list.get is in the for-loop, while our mixin method is before the for-loop,

instead of duplicating all the logic vanilla does, you could also just target something else that includes the index, like the List#get call in the loop

Could you elaborate on this? I duplicated vanilla logic cause onBreakChatMessageLines used a @Local (@Local List<OrderedText> list)

target @At(value = "INVOKE", target = "Ljava/util/List;add(ILjava/lang/Object;)V", remap = false) and capture the argument, this would get the same value as what the @Local that was breaking compat had

Did I achieve what you wanted correctly in this commit?

[IHaxU]

Seems it broke compatibility with the worlds most fragile client (Feather)

[IHaxU]

There we go

[RacoonDog]

@Redirect is very bad for mod compatibility, capture the return value with a @ModifyExpressionValue instead