Skip to content

Codec Issue: 'getValue' function name collision in combined Uplink/Downlink scripts #72

Open
@WAWXuan

Description

@WAWXuan

A getValue function name collision occurs when combining the separated uplink decoder and downlink encoder scripts for platform use (e.g., ChirpStack).

The downlink encoder's getValue (value->key lookup, throws error), likely established around commit dfec81b, overwrites the uplink decoder's getValue (key->value lookup).

This causes uplink decoding to fail (e.g., with "not match in {...}" error) as it calls the incorrect helper function.

Recommendation:
Rename the downlink encoder's getValue helper (e.g., to getKeyFromValue or findKeyByValue) to resolve the conflict in combined scripts.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions