Fix EntitySummonItem summoning in blocking tiles & not decrementing on usages
#761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not perfect but should be sufficient "Blocks" means blocking tiles with respect with the target entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #744.
Basically,
EntitySummonItemwas not correcting implementing a subclass ofStackableItemwhere its subclasses should always invokeStackableItem#interactOn(boolean)(at least whentruefor it to work properly) in their overrides of theinteractOnmethod. Also, I discovered that it does not check whether the placing target is solid (blocking) to the entity, so that players may pass through a solid tile by placing a boat on it.The code content is not perfect as a solution due to the codebase (and class) structures, but should be sufficient to solve those bugs. What I meant by this is that it should be more polymorphic and whatever, so that duplicated attributes may not have to be repeated (using configuring/attributive/etc. objects) and dummy objects may not be used.