Fix parsing bug where includes are skipped #686
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielrussoc
added a commit
to gabrielrussoc/EternalTerminal
that referenced
this pull request
Jul 11, 2025
Upstream PR: MisterTea#686 The SSH config parser avoids parsing everything inside a `Host` block that does not match the host we are trying to connect to. This makes sense, but the implementation fails on some cases. Consider the following: `et host.company` ``` Host other.company User someone Include ~/.ssh/host.company ``` And inside `~/.ssh/host.company` we have: ``` Host host.company User gabriel ``` The way the parser works now is: * Sees the `Host other.company` and sets `parsing = 0` because it does not match the target `host.company`. * Skips processing the `Include` completely because `parsing = 0`. * Misses the actual configs defined for `Host host.company`. This PR simply does not ignore `Include` directives to avoid such cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSH config parser avoids parsing everything inside a
Hostblock that does not match the host we are trying to connect to.This makes sense, but the implementation fails on some cases. Consider the following:
et host.companyAnd inside
~/.ssh/host.companywe have:The way the parser works now is:
Host other.companyand setsparsing = 0because it does not match the targethost.company.Includecompletely becauseparsing = 0.Host host.company.This PR simply does not ignore
Includedirectives to avoid such cases.