Fix multiple options accepted for single-value options #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CirctleCI tests fail because "Job was rejected because resource class medium, image ubuntu-2004:202101-01 is not a valid resource class ". |
|
Thanks! |
|
@p12tic your PR is failing CI. Can you take a look? The circle CI tests are broken but the others should pass. |
Currently single-value options such as --tunnel will accept multiple values, e.g. --tunnel "<...>" --tunnel "<...>". Confusingly for the user only the last value will be used without any warning. This commit fixes this by emitting an error message and exiting the program if multiple option values were supplied when single value was expected.
p12tic
force-pushed
the
disallow-multiple-options-for-single-value-options
branch
from
1f37678 to
d0cb452
Compare
|
@MisterTea Should be good now. Sorry for wasting your time with the first iteration, I should have been more careful. |
|
@MisterTea Just a friendly ping :) Thanks a lot for your time. |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently single-value options such as --tunnel will accept multiple values, e.g. --tunnel "<...>" --tunnel "<...>". Confusingly for the user only the last value will be used without any warning.
This commit fixes this by emitting an error message and exiting the program if multiple option values were supplied when single value was expected.
There are several more cases where this same approach could be applied, but these are not as trivial to map to the newly added function (e.g.
result["terminal-path"].as<string>()), so I left them as is.