Coalesce console output#742
Open
scramsby wants to merge 1 commit into
Open
Conversation
The ET client wrote each received TERMINAL_BUFFER packet to stdout individually. When the server sent a burst of output (e.g. a tmux session switch redrawing multiple panes), each packet became a separate write() to the local terminal, causing the terminal emulator to render intermediate states (screen-clear in one frame, repaint in the next) — producing visible flicker. Fix: accumulate all TERMINAL_BUFFER payloads received in a single select() wake into one string, then write once after draining the packet queue.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #742 +/- ##
==========================================
- Coverage 86.95% 86.90% -0.06%
==========================================
Files 70 70
Lines 5282 5284 +2
Branches 490 491 +1
==========================================
- Hits 4593 4592 -1
- Misses 689 692 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ET client wrote each received TERMINAL_BUFFER packet to stdout individually. When the server sent a burst of output (e.g. a tmux session switch redrawing multiple panes), each packet became a separate write() to the local terminal, causing the terminal emulator to render intermediate states (screen-clear in one frame, repaint in the next) — producing visible flicker.
Fix: accumulate all TERMINAL_BUFFER payloads received in a single select() wake into one string, then write once after draining the packet queue.
To test:
Connect to Linux machine from Windows machine using ET.
Switch between tmux sessions with sidebar panes — verify no flicker and no partial screen erasure.