DRAFT: Add support for ProSim for the A322 #2042
Conversation
|
Build for this pull request: |
|
Build for this pull request: |
|
Great! |
|
Sounds good to me. I can look to add that
…On Mon, Mar 24, 2025 at 2:21 AM Koseng ***@***.***> wrote:
Great!
Since the Prosim userbase is probably smaller than the regular user base,
I thought not force everyone to the "pythonnet" package. Everyone will be
annoyed again by the popup message. I thought about making a special check
for that, only in case the prosim scripts are started. So a new script
dependent check and message.
—
Reply to this email directly, view it on GitHub
<#2042 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHPHYNOHJQ5QFIQGIOIGTT2V6P7VAVCNFSM6AAAAABZTRT7QKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBXGAYTGMJXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: Koseng]*Koseng* left a comment
(MobiFlight/MobiFlight-Connector#2042)
<#2042 (comment)>
Great!
Since the Prosim userbase is probably smaller than the regular user base,
I thought not force everyone to the "pythonnet" package. Everyone will be
annoyed again by the popup message. I thought about making a special check
for that, only in case the prosim scripts are started. So a new script
dependent check and message.
—
Reply to this email directly, view it on GitHub
<#2042 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHPHYNOHJQ5QFIQGIOIGTT2V6P7VAVCNFSM6AAAAABZTRT7QKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBXGAYTGMJXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
But on the other hand, that package also might be valuable in the future and we are still in beta. So for now just leave it like it is. |
| while True: | ||
| dataref = self.prosim_client.get_dataref_value(self.cdu_dataref_name) | ||
| if dataref: | ||
| asyncio.run_coroutine_threadsafe(self.mobiflight.send(create_mobi_json(dataref)), self.event_loop) |
There was a problem hiding this comment.
Since we are polling, I would propose to store the current value and only send to mobiflight if the value has changed. There is also an internal check in mobiflight before sending to the winwing device, but not sending at all to mobiflight would be the best. I assume each 100ms the same value is returned.
There was a problem hiding this comment.
Or this currently is just a temp solution, since there also is the callback based stuff.
There was a problem hiding this comment.
Yep exactly, if you check the 737 implementation, I have exactly that, where I store the last value sent and only send if there is a diff. Just need to update the a320 implementation to match
There was a problem hiding this comment.
The issue with the callback solution is that pythonnet runs it on the C# side, and it has problems interoping with asyncio. I was never able to get the callback solution to work nicely, so I think polling with checking should be good enough most likely
|
@tristanmcpherson will you adjust that PR to the GraphQL based version? And then please adjust the title to add the 737. |
|
Can do!
…On Mon, Apr 7, 2025 at 1:46 PM Koseng ***@***.***> wrote:
@tristanmcpherson <https://github.com/tristanmcpherson> will you adjust
that PR to the GraphQL based version? And then please adjust the title to
add the 737.
—
Reply to this email directly, view it on GitHub
<#2042 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHPHYP7LXMXHGNMPR5VLA32YK2WFAVCNFSM6AAAAABZTRT7QKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBUGEYTIMBXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: Koseng]*Koseng* left a comment
(MobiFlight/MobiFlight-Connector#2042)
<#2042 (comment)>
@tristanmcpherson <https://github.com/tristanmcpherson> will you adjust
that PR to the GraphQL based version? And then please adjust the title to
add the 737.
—
Reply to this email directly, view it on GitHub
<#2042 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHPHYP7LXMXHGNMPR5VLA32YK2WFAVCNFSM6AAAAABZTRT7QKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOBUGEYTIMBXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Draft for now to trigger a build