Fix parsing failing due to new TaskBacktrace activity log attachment #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure when
TaskBacktrace
was introduced but it seems to be a new of the section attachment. Example value from after tokenization:The second attachment is the one we currently parse, support for which was introduced in #204.
The first attachment is new – and currently
XCLogParser
fails when parsing it because it expects all attachments to be a task metric.This PR adds support for parsing it. The JSON value is quite odd – I decided to parse just the
category
anddescription
, discarding theidentifier
andframeKind
. If you feel strongly, I can try adding support for those as well, but I'm not sure how they would be useful.