Apply suggestions from code review

Co-authored-by: Brentley Jones <github@brentleyjones.com>
Signed-off-by: Luis Padron <heyluispadron@gmail.com>

Author: luispadron

test/internal/pbxproj_partials/write_pbxproj_prefix_tests.bzl

@@ -53,9 +53,9 @@ def _write_pbxproj_prefix_test_impl(ctx):
         import_index_build_indexstores = (
             ctx.attr.import_index_build_indexstores
         ),
-        legacy_index_import = ctx.attr.legacy_index_import,
         index_import = ctx.attr.index_import,
         install_path = "a/project.xcodeproj",
+        legacy_index_import = ctx.attr.legacy_index_import,
         minimum_xcode_version = ctx.attr.minimum_xcode_version,
         platforms = ctx.attr.platforms,
         post_build_script = ctx.attr.post_build_script,
@@ -145,8 +145,8 @@ write_pbxproj_prefix_test = unittest.make(
         "default_xcode_configuration": attr.string(mandatory = True),
         "execution_root_file": attr.string(mandatory = True),
         "import_index_build_indexstores": attr.bool(mandatory = True),
-        "legacy_index_import": attr.string(mandatory = True),
         "index_import": attr.string(mandatory = True),
+        "legacy_index_import": attr.string(mandatory = True),
         "minimum_xcode_version": attr.string(mandatory = True),
         "platforms": attr.string_list(mandatory = True),
         "post_build_script": attr.string(),
@@ -182,8 +182,8 @@ def write_pbxproj_prefix_test_suite(name):
             default_xcode_configuration,
             execution_root_file,
             import_index_build_indexstores,
-            legacy_index_import,
             index_import,
+            legacy_index_import,
             minimum_xcode_version,
             platforms,
             post_build_script = None,
@@ -207,8 +207,8 @@ def write_pbxproj_prefix_test_suite(name):
             default_xcode_configuration = default_xcode_configuration,
             execution_root_file = execution_root_file,
             import_index_build_indexstores = import_index_build_indexstores,
-            legacy_index_import = legacy_index_import,
             index_import = index_import,
+            legacy_index_import = legacy_index_import,
             minimum_xcode_version = minimum_xcode_version,
             platforms = platforms,
             post_build_script = post_build_script,
@@ -237,8 +237,8 @@ def write_pbxproj_prefix_test_suite(name):
         default_xcode_configuration = "Debug",
         execution_root_file = "an/execution/root/file",
         import_index_build_indexstores = True,
-        legacy_index_import = "some/path/to/legacy/index_import",
         index_import = "some/path/to/index_import",
+        legacy_index_import = "some/path/to/legacy/index_import",
         minimum_xcode_version = "14.2.1",
         platforms = [
             "MACOS",
@@ -303,8 +303,8 @@ def write_pbxproj_prefix_test_suite(name):
         default_xcode_configuration = "Release",
         execution_root_file = "an/execution/root/file",
         import_index_build_indexstores = False,
-        legacy_index_import = "some/path/to/legacy/index_import",
         index_import = "some/path/to/index_import",
+        legacy_index_import = "some/path/to/legacy/index_import",
         platforms = [
             "MACOS",
             "IOS_DEVICE",

tools/generators/pbxproj_prefix/test/PBXProjectBuildSettingsTests.swift

@@ -11,7 +11,7 @@ class PBXProjectBuildSettingsTests: XCTestCase {
 
         let config = "rxcp_custom_config"
         let importIndexBuildIndexstores = false
-		let legacyIndexImport = "external/legacy-index-import"
+        let legacyIndexImport = "external/legacy-index-import"
         let indexImport = "external/index-import"
         let indexingProjectDir = "/some/indexing/project dir"
         let projectDir = "/some/project dir"
@@ -85,7 +85,7 @@ class PBXProjectBuildSettingsTests: XCTestCase {
         let buildSettings = Generator.pbxProjectBuildSettings(
             config: config,
             importIndexBuildIndexstores: importIndexBuildIndexstores,
-			legacyIndexImport: legacyIndexImport,
+            legacyIndexImport: legacyIndexImport,
             indexImport: indexImport,
             indexingProjectDir: indexingProjectDir,
             projectDir: projectDir,