Fix rsync on macOS 15.4

15.4's `rsync` has a bug that requires the src to have write permissions. We normally shouldn't do this as it modifies the Bazel output base, so we limit this to only macOS 15.4 (as it’s fixed in 15.5).

Also fixes a slight bug in the `patch_dsym` function.

Signed-off-by: Brentley Jones <github@brentleyjones.com>

Author: brentleyjones

xcodeproj/internal/bazel_integration_files/copy_dsyms.sh

@@ -3,18 +3,23 @@
 set -euo pipefail
 
 function patch_dsym() {
-  readonly dsym_name="$1"
-  readonly binary_name="${dsym_name%%.*}"
-  readonly binary_path="${dsym_name}/Contents/Resources/DWARF/${binary_name}"
+  local dsym_name="$1"
+
+  shopt -s extglob
+  local binary_name="${dsym_name%.dSYM}"
+  binary_name="${binary_name%@(.app|.appex|.bundle|.dext|.kext|.framework|.pluginkit|.systemextension|.xctest|.xpc)}"
+  shopt +s extglob
+
+  local binary_path="${dsym_name}/Contents/Resources/DWARF/${binary_name}"
 
   if [[ ! -f "$binary_path" ]]; then
     echo "dSYM DWARF ${binary_path} does not exist." \
     "Skip dSYM patch."
     return 1
   fi
 
+  local dwarf_uuid
   dwarf_uuid=$(dwarfdump --uuid "${binary_path}" | cut -d ' ' -f 2)
-  readonly dwarf_uuid
   if [[ -z "${dwarf_uuid// /}" ]]; then
     echo "Failed to get dSYM uuid." \
     "Skip dSYM patch."
@@ -44,6 +49,14 @@ EOF
 if [[ -n "${BAZEL_OUTPUTS_DSYM:-}" ]]; then
   cd "${BAZEL_OUT%/*}"
 
+  if [[ $(sw_vers -productVersion | cut -d '.' -f 1-2) == "15.4" ]]; then
+    # 15.4's `rsync` has a bug that requires the src to have write permissions.
+    # We normally shouldn't do this as it modifies the bazel output base, so we
+    # limit this to only macOS 15.4.
+    # shellcheck disable=SC2046
+    chmod -R +w $(xargs -n1 <<< "$BAZEL_OUTPUTS_DSYM")
+  fi
+
   # shellcheck disable=SC2046
   rsync \
     --copy-links \

xcodeproj/internal/bazel_integration_files/copy_outputs.sh

@@ -30,6 +30,13 @@ if [[ "$ACTION" != indexbuild ]]; then
       # rpaths to work
       ln -sfh "$PWD/$BAZEL_OUTPUTS_PRODUCT_BASENAME" "$TARGET_BUILD_DIR/$PRODUCT_NAME"
     else
+      if [[ $(sw_vers -productVersion | cut -d '.' -f 1-2) == "15.4" ]]; then
+        # 15.4's `rsync` has a bug that requires the src to have write
+        # permissions. We normally shouldn't do this as it modifies the bazel
+        # output base, so we limit this to only macOS 15.4.
+        chmod -R +w "$BAZEL_OUTPUTS_PRODUCT_BASENAME"
+      fi
+
       # Product is a bundle
       rsync \
         --copy-links \

xcodeproj/internal/templates/incremental_installer.sh

@@ -74,6 +74,13 @@ dest_dir="$(dirname "${dest}")"
 # Copy over `xcschemes`
 readonly dest_xcschemes="$dest/xcshareddata/xcschemes"
 
+if [[ $(sw_vers -productVersion | cut -d '.' -f 1-2) == "15.4" ]]; then
+  # 15.4's `rsync` has a bug that requires the src to have write permissions.
+  # We normally shouldn't do this as it modifies the bazel output base, so we
+  # limit this to only macOS 15.4.
+  chmod -R +w "$src_xcschemes"
+fi
+
 mkdir -p "$dest_xcschemes"
 rsync \
   --archive \

xcodeproj/internal/templates/legacy_installer.sh

@@ -127,6 +127,13 @@ fi
 
 # Sync over the project, changing the permissions to be writable
 
+if [[ $(sw_vers -productVersion | cut -d '.' -f 1-2) == "15.4" ]]; then
+  # 15.4's `rsync` has a bug that requires the src to have write permissions.
+  # We normally shouldn't do this as it modifies the bazel output base, so we
+  # limit this to only macOS 15.4.
+  chmod -R +w "$src"
+fi
+
 # Don't touch project.xcworkspace as that will make Xcode prompt
 rsync \
   --archive \