improve naming

Author: Karim Alweheshy

xcodeproj/internal/templates/custom_toolchain_symlink.sh

@@ -12,11 +12,12 @@ XCODE_RAW_VERSION=$(xcodebuild -version | head -n 1)
 
 # Define toolchain names
 TOOLCHAIN_NAME="${TOOLCHAIN_NAME_BASE}"
-HOME_TOOLCHAIN_NAME="BazelRulesXcodeProj ${XCODE_VERSION}"
+HOME_TOOLCHAIN_NAME="BazelRulesXcodeProj${XCODE_VERSION}"
 USER_TOOLCHAIN_PATH="/Users/$(id -un)/Library/Developer/Toolchains/${HOME_TOOLCHAIN_NAME}.xctoolchain"
 BUILT_TOOLCHAIN_PATH="$PWD/$TOOLCHAIN_DIR"
 
-mkdir -p "$TOOLCHAIN_DIR"
+mkdir -p "$USER_TOOLCHAIN_PATH"
+mkdir -p "$BUILT_TOOLCHAIN_PATH"
 
 while IFS='=' read -r key value; do
     value="$PWD/$value"
@@ -63,29 +64,24 @@ cat > "$TOOLCHAIN_DIR/ToolchainInfo.plist" << EOF
   <dict>
     <key>Aliases</key>
     <array>
-      <string>BazelRulesXcodeProj</string>
+      <string>${HOME_TOOLCHAIN_NAME}</string>
     </array>
     <key>CFBundleIdentifier</key>
-    <string>com.rules_xcodeproj.BazelRulesXcodeProj</string>
+    <string>com.rules_xcodeproj.BazelRulesXcodeProj.{$XCODE_VERSION}</string>
     <key>CompatibilityVersion</key>
     <integer>2</integer>
     <key>CompatibilityVersionDisplayString</key>
     <string>${XCODE_RAW_VERSION}</string>
     <key>DisplayName</key>
-    <string>BazelRulesXcodeProj (${XCODE_RAW_VERSION})</string>
+    <string>${HOME_TOOLCHAIN_NAME}</string>
     <key>ReportProblemURL</key>
     <string>https://github.com/MobileNativeFoundation/rules_xcodeproj</string>
     <key>ShortDisplayName</key>
-    <string>BazelRulesXcodeProj</string>
+    <string>${HOME_TOOLCHAIN_NAME}</string>
     <key>Version</key>
     <string>0.1.0</string>
   </dict>
 </plist>
 EOF
 
-# Remove existing symlink if present and create a new one in the user directory
-if [ -e "$USER_TOOLCHAIN_PATH" ]; then
-    rm -f "$USER_TOOLCHAIN_PATH"
-fi
 ln -s "$BUILT_TOOLCHAIN_PATH" "$USER_TOOLCHAIN_PATH"
-