Fix file permissions on macOS 15.4 #3141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adin Cebic <cebic.ad@gmail.com>
| @@ -31,6 +31,7 @@ if [[ "$ACTION" != indexbuild ]]; then | |||
| ln -sfh "$PWD/$BAZEL_OUTPUTS_PRODUCT_BASENAME" "$TARGET_BUILD_DIR/$PRODUCT_NAME" | |||
| else | |||
| # Product is a bundle | |||
| chmod -R +w "$BAZEL_OUTPUTS_PRODUCT_BASENAME" "$TARGET_BUILD_DIR" # Starting on MacOS 15.4, rsync will fail if it does not have write access on the src or dst directory | |||
There was a problem hiding this comment.
Does this adjust permissions in bazel-out? If so, we can't do that.
|
This seems odd. rsync shouldn't have to have write access to where its copying from 🧐 |
Makes sens. Didn't give it much thought, we had it as a patch for quite some time, I'll take a look at it again. |
|
Adjusted in #3157. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been changes to
rsyncon macOS 15.4 which require us to have write permissions here.