Fix rsync on macOS 15.4
#3157
Merged
Fix rsync on macOS 15.4
#3157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
approved these changes
Apr 1, 2025
|
Going to test once I update to 15.4 in a few mins |
|
confirmed this fixed on Square's repo, thank you! |
|
🙏 Thanks for scoping this to 15.4 ! |
mlequeux
approved these changes
Apr 1, 2025
15.4's `rsync` has a bug that requires the src to have write permissions. We normally shouldn't do this as it modifies the Bazel output base, so we limit this to only macOS 15.4 (as it’s fixed in 15.5). Also fixes a slight bug in the `patch_dsym` function. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/fix-rsync-on-macos-15.4
branch
from
bbe5153 to
4ce504d
Compare
3 tasks
|
@brentleyjones how do we know that the issue is fixed in MacOS 15.5 ? |
|
Not fixed yet, but basically promised to be. |
|
Still broken on MacOS 15.5b1, as expected |
|
In order to fix on 15.5 betas, if the issue is still present (Patches the 2.11.1 release) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
15.4's
rsynchas a bug that requires the src to have write permissions. We normally shouldn't do this as it modifies the Bazel output base, so we limit this to only macOS 15.4 (as it’s fixed in 15.5).Also fixes a slight bug in the
patch_dsymfunction.