Allow empty string value for xcschemes.env_value #3165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ghugues I think you need to sign off the commit. |
Signed-off-by: Guillaume Hugues <guillaume@amo.co>
ghugues
force-pushed
the
allow-empty-env-values
branch
from
0586254 to
7e98584
Compare
brentleyjones
approved these changes
Apr 18, 2025
| @@ -1142,7 +1142,7 @@ def _env_value(value, *, enabled = True): | |||
| checked in the scheme. An unchecked checkbox means Xcode won't | |||
| include that environment variable when running a target. | |||
| """ | |||
| if not value: | |||
There was a problem hiding this comment.
It would be nice to adjust the tests for this.
There was a problem hiding this comment.
This was not covered by unit tests so I add added a new suite with a couple tests. Let me know if this is what you had in mind.
Signed-off-by: Guillaume Hugues <guillaume@amo.co>
ghugues
force-pushed
the
allow-empty-env-values
branch
from
371e243 to
a8a9bf5
Compare
| @@ -2,13 +2,16 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library") | |||
| load(":info_constructors_tests.bzl", "info_constructors_test_suite") | |||
| load(":infos_from_json_tests.bzl", "infos_from_json_test_suite") | |||
| load(":write_schemes_tests.bzl", "write_schemes_test_suite") | |||
| load(":xcschemes_base_tests.bzl", "xcschemes_base_test_suite") | |||
There was a problem hiding this comment.
"base" isn't a good name for this, and xcschemes_ is redundant (we are in the xcschemes package).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode allows defining environment variables without a value. At runtime, sometimes only the presence of the environment variable is checked, not its value (e.g.
CG_NUMERICS_SHOW_BACKTRACE,CGBITMAP_CONTEXT_LOG_ERRORS, etc.).