-
Notifications
You must be signed in to change notification settings - Fork 98
Adopt latest index-import version (v6.1.0.1) to fix issue with libzstd.1.dylib #3174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt latest index-import version (v6.1.0.1) to fix issue with libzstd.1.dylib #3174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update fixtures and this same change needs to happen to rules_swift as well
This is the rules_swift pr: bazelbuild/rules_swift#1513 |
@luispadron awesome! Let me know when you have that release and I can update the version here |
@luispadron what do you mean exactly by "You'll need to update fixtures"? I'm not seeing that it is depending on index-import. |
All good on the fixtures, forgot that doesn't encode the exact version. You just need to accept the DCO. Thanks for the PR! |
ff8d42a
to
9c9109b
Compare
|
Head branch was pushed to by a user without write access
@samuelsainz could we update this as well for non-bzlmod users: https://github.com/MobileNativeFoundation/rules_xcodeproj/blob/main/xcodeproj/repositories.bzl#L124-L125 |
@luispadron sure, totally missed that one! |
Signed-off-by: Samuel Sainz <samuel.sainz@compass.com>
Signed-off-by: Samuel Sainz <samuel.sainz@compass.com>
Signed-off-by: Samuel Sainz <samuel.sainz@compass.com>
c167c05
to
4939ac5
Compare
Description
Update to latest
index-import
version In order to fix this issue withlibzstd.1.dylib