Skip to content

Adopt latest index-import version (v6.1.0.1) to fix issue with libzstd.1.dylib #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

samuelsainz
Copy link
Contributor

@samuelsainz samuelsainz commented May 6, 2025

Description

Update to latest index-import version In order to fix this issue with libzstd.1.dylib

ERROR: /Users/user.name/development/iOSApp/Sources/ios/SomeDirectory/ModuleName/BUILD.bazel:7:14: Compiling Swift module //Sources/ios/SomeDirectory/ModuleName:ModuleName failed: (Exit 6): worker failed: error executing SwiftCompile command (from target //Sources/ios/SomeDirectory/ModuleName:ModuleName)
  (cd /private/var/tmp/_bazel_user.name/6a5e437287601edde41b207a856d8f03/rules_xcodeproj.noindex/build_output_base/execroot/_main && \
  exec env - \
    APPLE_SDK_PLATFORM=iPhoneSimulator \
    APPLE_SDK_VERSION_OVERRIDE=18.4 \
    PATH=/bin:/usr/bin \
    XCODE_VERSION_OVERRIDE=16.3.0.16E140 \
  bazel-out/darwin_arm64-opt-exec-ST-d57f47055a04/bin/external/rules_swift+/tools/worker/worker swiftc @bazel-out/ios_sim_arm64-dbg-ios-sim_arm64-min16.0-applebin_ios-ST-6e2671526308/bin/Sources/ios/SomeDirectory/ModuleName/ModuleName.swiftmodule-0.params)
# Configuration: b0ceba1133f56978950e06b51b3c16e1564509c2be138544537871ebbdd13844
# Execution platform: @@platforms//host:host
dyld[5952]: Library not loaded: /opt/homebrew/opt/zstd/lib/libzstd.1.dylib
  Referenced from: <9F95D36C-F1F1-3C2B-A2B2-08DD7E0943D2> /private/var/tmp/_bazel_user.name/6a5e437287601edde41b207a856d8f03/rules_xcodeproj.noindex/build_output_base/external/rules_swift++non_module_deps+build_bazel_rules_swift_index_import_6_1/index-import
  Reason: tried: '/opt/homebrew/opt/zstd/lib/libzstd.1.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/zstd/lib/libzstd.1.dylib' (no such file), '/opt/homebrew/opt/zstd/lib/libzstd.1.dylib' (no such file)

@samuelsainz samuelsainz requested a review from a team as a code owner May 6, 2025 15:13
Copy link
Contributor

@luispadron luispadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update fixtures and this same change needs to happen to rules_swift as well

@luispadron
Copy link
Contributor

This is the rules_swift pr: bazelbuild/rules_swift#1513
we should probably update the rules_swift version in here once i make a release

@samuelsainz
Copy link
Contributor Author

samuelsainz commented May 6, 2025

@luispadron awesome! Let me know when you have that release and I can update the version here

@samuelsainz
Copy link
Contributor Author

samuelsainz commented May 6, 2025

@luispadron what do you mean exactly by "You'll need to update fixtures"? I'm not seeing that it is depending on index-import.
Sorry, first PR here and I'm still getting familiar with Bazel :) thanks!

@luispadron
Copy link
Contributor

All good on the fixtures, forgot that doesn't encode the exact version. You just need to accept the DCO.

Thanks for the PR!

@samuelsainz samuelsainz force-pushed the samuelsainz/update-index-import-to-fix-zstd branch from ff8d42a to 9c9109b Compare May 6, 2025 19:29
@brentleyjones brentleyjones enabled auto-merge (squash) May 6, 2025 20:12
@luispadron
Copy link
Contributor

2.8.2 has been released for rules_swift

auto-merge was automatically disabled May 6, 2025 20:29

Head branch was pushed to by a user without write access

@brentleyjones brentleyjones enabled auto-merge (squash) May 6, 2025 20:33
@luispadron luispadron disabled auto-merge May 6, 2025 20:41
@luispadron
Copy link
Contributor

@samuelsainz
Copy link
Contributor Author

@luispadron sure, totally missed that one!

@luispadron luispadron enabled auto-merge (squash) May 6, 2025 21:09
Signed-off-by: Samuel Sainz <samuel.sainz@compass.com>
Signed-off-by: Samuel Sainz <samuel.sainz@compass.com>
Signed-off-by: Samuel Sainz <samuel.sainz@compass.com>
@luispadron luispadron force-pushed the samuelsainz/update-index-import-to-fix-zstd branch from c167c05 to 4939ac5 Compare May 6, 2025 21:11
@luispadron luispadron merged commit 78856c9 into MobileNativeFoundation:main May 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest version of index-import depends on libzstd.1.dylib installed from brew
4 participants