fix: handle GeoJSON locations when computing distance between stops #2040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a bug where we calculate the distance between two stops incorrectly if there's a GeoJSON location between them. We currently fall back to Null Island (0, 0) when we can't get the coordinates of a stop time's stop (in this case, because there's no stop id for a GeoJSON location) which messes up our calculations and can lead to false positives for the fast_travel_between_far_stops notice. See this comment.
We also address false negatives for the fast_travel_between_consecutive_stops notice due to only comparing consecutive entries in stop_times.txt.
I'll write some tests once we're happy with the approach.
Closes #2031
Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything