Skip to content

[core][Item][NDArrayShape][NDArrayStrides] Unify containers #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 142 commits into from
Oct 21, 2025
Merged

[core][Item][NDArrayShape][NDArrayStrides] Unify containers #274

merged 142 commits into from
Oct 21, 2025

Conversation

shivasankarka
Copy link
Collaborator

@shivasankarka shivasankarka commented Oct 20, 2025 •
edited
Loading

This PR does the following,

  1. Unifies all main creation and manipulation methods of Item, Shape and Strides struct
  2. Implement all the correct Error types and fixes some memory errors in above structs.
  3. Adds news dtype aliases.
  4. Adds type information to variables in many places.
  5. Fixes some docstring errors that contained legacy code.
  6. Remove isize and intp in favor of int as Mojo doesn't support those anymore.

shivasankarka and others added 30 commits March 10, 2025 18:04
@shivasankarka
removed some typos
e9b6db3
@shivasankarka
fix typos in example
d589b50
@shivasankarka
Merge remote-tracking branch 'upstream/pre-0.7'
4f11dc3
@forfudan
[release] Merge pre-0.7 into main for the release of v0.7.0 (Mojo-Num…
2b72ef4 
…erics-and-Algorithms-group#251)

As title.
@shivasankarka
Merge remote-tracking branch 'upstream/main'
25c7796
@shivasankarka
updated to Mojo 25.4
3c3d5a3
@shivasankarka
update to Mojo 25.4
abd4fe8
@shivasankarka
update dependancies
6d46d59
@shivasankarka
fix format
533aa02
@shivasankarka
fix tests
a08b1a0
@shivasankarka
update to pixi
d52dbb7
@shivasankarka
fix github workflow
1e1f29a
@shivasankarka
fix github workflow
74d9a92
@shivasankarka
fix workflow
5fcf486
@shivasankarka
hopefully this fix works
fe07a23
@shivasankarka
fix ndarry formatting issue
183e4fb
@shivasankarka
fix formatting workflow
8b51f18
@shivasankarka
please work - formatter
827e855
@shivasankarka
fix format workflow
d92a7e4
@forfudan
Fix pre-commit issues
5bdca62
@forfudan
Update workflow
4c3ee57
@forfudan
Update workflow
bfc04a8
@shivasankarka
add load and save functions to io routines; update imports accordingly
e00ba89
@shivasankarka
Merge remote-tracking branch 'upstream/pre-0.8' into prev0.8
af116e9
@shivasankarka
added error types
a959745
@shivasankarka
updated file io methods
0a265ca
@shivasankarka
resolved name clashes.
03906cb
@shivasankarka
fix format
cbb8be9
@shivasankarka
fixed io errors
f8cf4d2
@shivasankarka
fix implicity conformance
b6099b7
@shivasankarka
update to Mojo 26.6 by fixing all copy errors
ad8d0b2
@shivasankarka
fix all tests for the Mojo 25.6 update
42cbf14
@shivasankarka
Merge remote-tracking branch 'origin/prev0.8' into prev0.8
0ed2a71
@shivasankarka
fix format
8b8198c
@shivasankarka
Merge remote-tracking branch 'upstream/pre-0.8' into improve_getter
3e5a51e
@shivasankarka
Merge remote-tracking branch 'upstream/pre-0.8' into complex_parameter
0ad8e3a
@shivasankarka
Merge branch 'complex_parameter' into prev0.8
b7c18c6
@shivasankarka
Merge branch 'improve_getter' into prev0.8
175c98d
@shivasankarka
Update manipulation.mojo
ffc564f
@shivasankarka
fix slice copy
c2538b1
@shivasankarka
fix docstring in complex array
6301088
@shivasankarka
fix datatypes errors
5df90cd
@shivasankarka
update DType and ComplexDType aliases
ac3081b
@shivasankarka
fix dtype errors
8412a83
@shivasankarka
fix test errors caused by dtype mismatch.
9e37dcd
@shivasankarka
Merge branch 'improve_getter' into prev0.8
5069b8d
@shivasankarka
remove comments
4dee55c
@shivasankarka
upgrade pixi
5317186
@shivasankarka
Update modular to ">=25.6.1,<26"
45f076c
@shivasankarka
unify the API of ndshape, ndstrides, item
11174dd
@shivasankarka
update item. mojo with slicing methods.
f757011
@shivasankarka
add row_major and col_major methods to ndshape and ndstrides.
9e823bc
@shivasankarka
fix some issues with memory errors
61805fb
@shivasankarka
fix error messages in item, shape, strides.
95a00ce
forfudan
forfudan approved these changes Oct 20, 2025
View reviewed changes
Copy link
Collaborator

@forfudan forfudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inpt -> int looks good to me. We should keep the core features of numpy but not necessarily mimic it everywhere.

@shivasankarka shivasankarka merged commit 3876690 into Mojo-Numerics-and-Algorithms-group:pre-0.8 Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@forfudan forfudan forfudan approved these changes

@MadAlex1997 MadAlex1997 Awaiting requested review from MadAlex1997

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shivasankarka @forfudan