Skip to content

Conversation

justinngan92
Copy link
Collaborator

  • remove sphinx action

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (cc0fb4a) to head (8ac2d27).
Report is 8 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   87.30%   87.28%   -0.03%     
==========================================
  Files          16       16              
  Lines        4522     4514       -8     
==========================================
- Hits         3948     3940       -8     
  Misses        574      574              

see 8 files with indirect coverage changes

* remove sphinx action
@justinngan92
Copy link
Collaborator Author

justinngan92 commented Sep 20, 2024

Removed sphinx-action (uses: ammaraskar/sphinx-action@master) and instead use build command directly.

The workflow successfully run up to the push action - which failed because not owner of repo.

Next commit will revert the workflow to on: pull_request branches: [ gh-pages ]

Copy link
Member

@ccaprani ccaprani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the doc build dependecies should be in a requirements.txt like for pycba??

https://github.com/ccaprani/pycba/blob/main/docs/requirements.txt

@justinngan92
Copy link
Collaborator Author

I think the doc build dependecies should be in a requirements.txt like for pycba??

https://github.com/ccaprani/pycba/blob/main/docs/requirements.txt

Is this what you are refering to?

https://github.com/MonashSmartStructures/ospgrillage/blob/main/docs/requirements.txt

@ccaprani
Copy link
Member

ccaprani commented May 2, 2025

Might not need pydata-sphinx-theme in yml but accepting for now.

@ccaprani ccaprani merged commit a9e7459 into MonashSmartStructures:main May 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants