-
Notifications
You must be signed in to change notification settings - Fork 13
Fix numpy 2 and dependency compatibility issue #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* version that works under numpy 2.0 * Not yet check with numpy 1.0 or with other dependency combinations (e.g., scipy)
Some tests might fail here. As part of this fix, the unit tests will be reviewed and revised Update: test failed due to openseespylinux package - similar errors to those here zhuminjie/OpenSeesPy#123 |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
==========================================
- Coverage 87.30% 87.11% -0.19%
==========================================
Files 16 16
Lines 4522 4665 +143
==========================================
+ Hits 3948 4064 +116
- Misses 574 601 +27
🚀 New features to boost your workflow:
|
78ab02c should work for both numpy 1 and numpy 2 Update: Test also passed with numpy v2.2.5. |
Should we consider updating pyproject.toml? removing the numpy version requirement dependencies = [ |
Deploy a fix for numpy 2's breaking changes
Multiple commits to follow to ensure all dependency works