Skip to content

Conversation

justinngan92
Copy link
Collaborator

Deploy a fix for numpy 2's breaking changes

Multiple commits to follow to ensure all dependency works

* version that works under numpy 2.0
* Not yet check with numpy 1.0 or with other dependency combinations (e.g., scipy)
@justinngan92
Copy link
Collaborator Author

justinngan92 commented Apr 16, 2025

Some tests might fail here. As part of this fix, the unit tests will be reviewed and revised

Update: test failed due to openseespylinux package - similar errors to those here zhuminjie/OpenSeesPy#123

@justinngan92
Copy link
Collaborator Author

justinngan92 commented Apr 22, 2025

7e5e6fa resolved linus BLAS dependency issue.

Next is to resolve tests assertions

Update: tests fix and pass in 78ab02c

- improve assertion for strings with parsing and comparing parts
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.38693% with 45 lines in your changes missing coverage. Please review.

Project coverage is 87.11%. Comparing base (cc0fb4a) to head (78ab02c).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/ospgrillage/osp_grillage.py 64.28% 40 Missing ⚠️
src/ospgrillage/members.py 66.66% 2 Missing ⚠️
src/ospgrillage/load.py 80.00% 1 Missing ⚠️
src/ospgrillage/postprocessing.py 75.00% 1 Missing ⚠️
tests/test_load.py 97.43% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   87.30%   87.11%   -0.19%     
==========================================
  Files          16       16              
  Lines        4522     4665     +143     
==========================================
+ Hits         3948     4064     +116     
- Misses        574      601      +27     
Files with missing lines Coverage Δ
src/ospgrillage/__init__.py 100.00% <100.00%> (ø)
src/ospgrillage/mesh.py 91.42% <100.00%> (-0.01%) ⬇️
src/ospgrillage/utils.py 88.85% <ø> (ø)
tests/test_benchmark.py 99.10% <100.00%> (ø)
tests/test_osp_grillage.py 97.29% <100.00%> (+0.27%) ⬆️
src/ospgrillage/load.py 67.89% <80.00%> (+0.39%) ⬆️
src/ospgrillage/postprocessing.py 88.59% <75.00%> (-0.60%) ⬇️
tests/test_load.py 99.75% <97.43%> (-0.25%) ⬇️
src/ospgrillage/members.py 79.13% <66.66%> (+0.18%) ⬆️
src/ospgrillage/osp_grillage.py 81.31% <64.28%> (-0.90%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justinngan92
Copy link
Collaborator Author

justinngan92 commented Apr 22, 2025

78ab02c should work for both numpy 1 and numpy 2

Update: Test also passed with numpy v2.2.5.

@justinngan92
Copy link
Collaborator Author

Should we consider updating pyproject.toml? removing the numpy version requirement

dependencies = [
"openseespy>=3.2.2.6",
"opsvis~=0.95.5",
"vfo>=0.0.6",
"matplotlib",
"numpy~=1.24.4",
"pandas",
"scipy~=1.10.1",
"xarray",
]

@ccaprani ccaprani merged commit 8c02474 into MonashSmartStructures:main May 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants