test: add tests to anoncreds cred def revocation fix

Yuki I · Yuki I · commit dd4ee76c0a3b · 2025-04-15T00:31:34.000Z
diff --git a/acapy_agent/anoncreds/default/legacy_indy/tests/test_registry.py b/acapy_agent/anoncreds/default/legacy_indy/tests/test_registry.py
@@ -47,6 +47,8 @@
     RevRegDefValue,
 )
 from ....models.schema import AnonCredsSchema, GetSchemaResult, SchemaResult
+from .....core.profile import Profile
+from .....wallet.did_info import DIDInfo
 
 B58 = alphabet if isinstance(alphabet, str) else alphabet.decode("ascii")
 INDY_DID = rf"^(did:sov:)?[{B58}]{{21,22}}$"
@@ -905,6 +907,95 @@ async def test_register_revocation_list_with_author_role(
         assert mock_create_record.called
         assert mock_send_revoc_reg_entry.called
 
+    @mock.patch.object(
+        IndyLedgerRequestsExecutor,
+        "get_ledger_for_identifier",
+        return_value=(
+            "mock_ledger_id",
+            mock.MagicMock(
+                spec=BaseLedger,
+                send_revoc_reg_entry=mock.CoroutineMock(return_value="mock_seq_no"),
+                __aenter__=mock.CoroutineMock(return_value=mock.MagicMock()),
+                __aexit__=mock.CoroutineMock(return_value=None),
+                profile=mock.MagicMock(spec=Profile),
+            ),
+        ),
+    )
+    @mock.patch.object(AskarAnoncredsProfileSession, "handle")
+    async def test_register_revocation_list_passes_profile(
+        self, mock_askar_handle, mock_get_ledger_for_id
+    ):
+        """Test register_revocation_list passes profile kwarg via helper."""
+        self.profile.inject_or = mock.MagicMock()
+
+        test_profile = self.profile
+
+        test_rev_reg_def = RevRegDef(
+            tag="tag",
+            cred_def_id="IssuerDID:3:CL:1:tag",
+            value=RevRegDefValue(
+                max_cred_num=100, public_keys={}, tails_hash="", tails_location=""
+            ),
+            issuer_id="IssuerDID",
+            type="CL_ACCUM",
+        )
+        test_rev_list = RevList(
+            issuer_id="IssuerDID",
+            current_accumulator="dummy_accum_value",
+            revocation_list=[0],
+            timestamp=1234567890,
+            rev_reg_def_id="IssuerDID:4:IssuerDID:3:CL:1:tag:CL_ACCUM:tag",
+        )
+
+        await self.registry.register_revocation_list(
+            test_profile,
+            test_rev_reg_def,
+            test_rev_list,
+            {},
+        )
+
+        mock_ledger_instance = mock_get_ledger_for_id.return_value[1]
+
+        mock_ledger_instance.send_revoc_reg_entry.assert_called_once()
+
+        _call_args, call_kwargs = mock_ledger_instance.send_revoc_reg_entry.call_args
+
+        assert "profile" in call_kwargs
+        assert call_kwargs["profile"] is test_profile
+        assert call_kwargs["write_ledger"] is True
+
+    async def test_registry_txn_submit_passes_profile(self):
+        """Test registry txn_submit passes profile kwarg to ledger txn_submit."""
+        mock_ledger = mock.MagicMock(BaseLedger, autospec=True)
+        mock_ledger.txn_submit = mock.CoroutineMock(return_value="mock_ledger_response")
+        mock_ledger.__aenter__ = mock.CoroutineMock(return_value=mock_ledger)
+        mock_ledger.__aexit__ = mock.CoroutineMock(return_value=None)
+
+        test_profile = self.profile
+        test_txn_data = '{"a": 1}'
+        test_sign_did = mock.MagicMock(spec=DIDInfo)
+
+        await self.registry.txn_submit(
+            ledger=mock_ledger,
+            ledger_transaction=test_txn_data,
+            sign=True,
+            taa_accept=True,
+            sign_did=test_sign_did,
+            write_ledger=True,
+            profile=test_profile,
+        )
+
+        mock_ledger.txn_submit.assert_called_once()
+
+        _call_args, call_kwargs = mock_ledger.txn_submit.call_args
+
+        assert "profile" in call_kwargs
+        assert call_kwargs["profile"] is test_profile
+        assert call_kwargs["sign"] is True
+        assert call_kwargs["taa_accept"] is True
+        assert call_kwargs["sign_did"] is test_sign_did
+        assert call_kwargs["write_ledger"] is True
+
     @mock.patch.object(
         ConnRecord,
         "retrieve_by_id",
diff --git a/acapy_agent/ledger/indy_vdr.py b/acapy_agent/ledger/indy_vdr.py
@@ -1380,7 +1380,11 @@ async def send_revoc_reg_entry(
             try:
                 LOGGER.debug("Submitting to ledger")
                 resp = await self._submit(
-                    request, True, sign_did=did_info, write_ledger=write_ledger
+                    request,
+                    True,
+                    sign_did=did_info,
+                    write_ledger=write_ledger,
+                    profile=current_profile,
                 )
                 LOGGER.debug("Received ledger response")
                 return {"result": resp}
diff --git a/acapy_agent/ledger/tests/test_indy_vdr.py b/acapy_agent/ledger/tests/test_indy_vdr.py
@@ -26,13 +26,28 @@
     VdrError,
 )
 
+from ...core.profile import Profile
+from ...storage.askar import AskarStorage
+from ..util import TAA_ACCEPTED_RECORD_TYPE
+
 WEB = DIDMethod(
     name="web",
     key_types=[ED25519],
     rotation=True,
     holder_defined_did=HolderDefinedDid.REQUIRED,
 )
 
+TEST_TENANT_DID = "WgWxqztrNooG92RXvxSTWv"
+TEST_TENANT_VERKEY = "TenantVerkeyyyyyyyyyyyyyyyyyyyyyy"
+TEST_SCHEMA_SEQ_NO = 4935
+TEST_CRED_DEF_TAG = "tenant_tag"
+TEST_REV_REG_TAG = "rev_tag_1"
+
+TEST_CRED_DEF_ID = f"{TEST_TENANT_DID}:3:CL:{TEST_SCHEMA_SEQ_NO}:{TEST_CRED_DEF_TAG}"
+TEST_REV_REG_DEF_ID = (
+    f"{TEST_TENANT_DID}:4:{TEST_CRED_DEF_ID}:CL_ACCUM:{TEST_REV_REG_TAG}"
+)
+
 
 @pytest.fixture()
 async def ledger():
@@ -1265,3 +1280,191 @@ async def test_rotate_did_keypair(self, ledger: IndyVdrLedger):
             ):
                 ledger.profile.context.injector.bind_instance(DIDMethods, DIDMethods())
                 await ledger.rotate_public_did_keypair()
+
+    async def _create_tenant_profile(
+        self, main_profile: Profile, name: str = "tenant"
+    ) -> Profile:
+        """Helper to create a secondary profile instance for testing."""
+        tenant_settings = {
+            "wallet.type": main_profile.settings.get("wallet.type", "askar-anoncreds"),
+            "auto_provision": True,
+            "wallet.name": f"{name}_wallet",
+            "wallet.key": f"test_tenant_key_for_{name}",
+            "wallet.key_derivation_method": "RAW",
+            "default_label": name,
+        }
+        tenant_profile = await create_test_profile(settings=tenant_settings)
+        tenant_profile.context.injector.bind_instance(
+            DIDMethods, main_profile.context.injector.inject(DIDMethods)
+        )
+        tenant_profile.context.injector.bind_instance(BaseCache, InMemoryCache())
+        tenant_profile.context.injector.bind_instance(
+            KeyTypes, main_profile.context.injector.inject(KeyTypes)
+        )
+        await tenant_profile.session()
+        return tenant_profile
+
+    @pytest.mark.asyncio
+    async def test_submit_signing_uses_passed_profile_context(
+        self, ledger: IndyVdrLedger
+    ):
+        """Test _submit calls sign_message using the passed profile context."""
+
+        tenant_profile = await self._create_tenant_profile(
+            ledger.profile, "submit_tenant"
+        )
+
+        mock_signing_did = DIDInfo("tenant_signer", "tenant_signer_vk", {}, SOV, ED25519)
+
+        mock_request_obj = mock.MagicMock(spec=indy_vdr.Request)
+        mock_request_obj.signature_input = b"data_to_be_signed"
+        mock_request_obj.body = json.dumps({"req": "data"})
+        mock_request_obj.set_signature = mock.Mock()
+        mock_request_obj.set_txn_author_agreement_acceptance = mock.Mock()
+
+        with mock.patch(
+            "acapy_agent.wallet.askar.AskarWallet.sign_message",
+            new_callable=mock.CoroutineMock,
+            return_value=b"mock_signature_from_patch",
+        ) as mock_sign_message_patch:
+            ledger.get_wallet_public_did = mock.CoroutineMock(
+                return_value=mock_signing_did
+            )
+            ledger.get_latest_txn_author_acceptance = mock.CoroutineMock(return_value={})
+
+            async with ledger:
+                await ledger._submit(
+                    mock_request_obj,
+                    sign=True,
+                    sign_did=mock_signing_did,
+                    taa_accept=False,
+                    write_ledger=False,
+                    profile=tenant_profile,
+                )
+
+        mock_sign_message_patch.assert_awaited_once_with(
+            message=b"data_to_be_signed", from_verkey=mock_signing_did.verkey
+        )
+        mock_request_obj.set_signature.assert_called_once_with(
+            b"mock_signature_from_patch"
+        )
+
+    @pytest.mark.asyncio
+    async def test_get_wallet_public_did_uses_passed_profile(self, ledger: IndyVdrLedger):
+        """Test get_wallet_public_did uses the explicitly passed profile."""
+        tenant_profile = await self._create_tenant_profile(
+            ledger.profile, "get_did_tenant"
+        )
+        mock_tenant_did = DIDInfo("did:sov:tenant_pub", "vk_pub", {}, SOV, ED25519)
+
+        with mock.patch(
+            "acapy_agent.wallet.askar.AskarWallet.get_public_did",
+            new_callable=mock.CoroutineMock,
+            return_value=mock_tenant_did,
+        ) as mock_get_public_patch:
+            result_did = await ledger.get_wallet_public_did(profile=tenant_profile)
+
+        assert result_did is mock_tenant_did
+        mock_get_public_patch.assert_awaited_once()
+
+    @pytest.mark.asyncio
+    async def test_get_latest_taa_uses_passed_profile(self, ledger: IndyVdrLedger):
+        """Test get_latest_txn_author_acceptance uses the explicitly passed profile."""
+        tenant_profile = await self._create_tenant_profile(
+            ledger.profile, "get_taa_tenant"
+        )
+        tenant_profile.context.injector.bind_instance(BaseCache, InMemoryCache())
+
+        with mock.patch.object(
+            AskarStorage, "find_all_records", return_value=[]
+        ) as mock_find_records_patch:
+            result_taa = await ledger.get_latest_txn_author_acceptance(
+                profile=tenant_profile
+            )
+
+        mock_find_records_patch.assert_awaited_once()
+        call_args, _call_kwargs = mock_find_records_patch.call_args
+        assert call_args[0] == TAA_ACCEPTED_RECORD_TYPE
+        assert call_args[1] == {"pool_name": ledger.pool_name}
+
+        assert result_taa == {}
+
+    @pytest.mark.asyncio
+    async def test_send_revoc_reg_entry_uses_passed_profile(self, ledger: IndyVdrLedger):
+        """Test send_revoc_reg_entry passes the correct profile to _submit."""
+        tenant_profile = await self._create_tenant_profile(
+            ledger.profile, "rev_entry_tenant"
+        )
+
+        async with tenant_profile.session() as session:
+            wallet = session.inject(BaseWallet)
+            tenant_did = await wallet.create_public_did(SOV, ED25519)
+
+        test_rev_reg_id = f"{tenant_did.did}:4:{TEST_CRED_DEF_ID}:CL_ACCUM:0"
+        test_reg_entry = {"ver": "1.0", "value": {"accum": "test_accum"}}
+
+        with (
+            mock.patch.object(
+                IndyVdrLedger,
+                "get_revoc_reg_def",
+                new=mock.CoroutineMock(
+                    return_value={"txn": {"data": {"revocDefType": "CL_ACCUM"}}}
+                ),
+            ),
+            mock.patch.object(
+                IndyVdrLedger,
+                "_create_revoc_reg_entry_request",
+                new=mock.CoroutineMock(
+                    return_value=mock.MagicMock(spec=indy_vdr.Request)
+                ),
+            ),
+            mock.patch.object(
+                IndyVdrLedger,
+                "_submit",
+                new=mock.CoroutineMock(return_value={"result": "mock_ok"}),
+            ) as mock_submit,
+        ):
+            async with ledger:
+                await ledger.send_revoc_reg_entry(
+                    revoc_reg_id=test_rev_reg_id,
+                    revoc_def_type="CL_ACCUM",
+                    revoc_reg_entry=test_reg_entry,
+                    write_ledger=True,
+                    profile=tenant_profile,
+                )
+
+        mock_submit.assert_awaited_once()
+        _, submit_kwargs = mock_submit.call_args
+        assert submit_kwargs.get("profile") is tenant_profile
+        assert submit_kwargs.get("sign_did").did == tenant_did.did
+
+    @pytest.mark.asyncio
+    async def test_ledger_txn_submit_uses_passed_profile(self, ledger: IndyVdrLedger):
+        """Test ledger txn_submit passes profile kwarg to _submit."""
+        tenant_profile = await self._create_tenant_profile(
+            ledger.profile, "txn_submit_tenant"
+        )
+
+        ledger._submit = mock.CoroutineMock(
+            return_value={"op": "REPLY", "result": {"status": "ok"}}
+        )
+
+        test_txn_data = '{"req": "data"}'
+        test_sign_did = mock.MagicMock(spec=DIDInfo)
+
+        await ledger.txn_submit(
+            test_txn_data,
+            sign=True,
+            sign_did=test_sign_did,
+            write_ledger=True,
+            profile=tenant_profile,
+        )
+
+        ledger._submit.assert_awaited_once()
+        _submit_args, submit_kwargs = ledger._submit.call_args
+        assert "profile" in submit_kwargs
+        assert submit_kwargs["profile"] is tenant_profile
+        assert _submit_args[0] == test_txn_data
+        assert submit_kwargs["sign"] is True
+        assert submit_kwargs["sign_did"] is test_sign_did
+        assert submit_kwargs["write_ledger"] is True
diff --git a/docker/Dockerfile.test b/docker/Dockerfile.test
@@ -11,7 +11,8 @@ WORKDIR /usr/src/app
 
 RUN pip install --no-cache-dir poetry==2.1.1
 
-COPY ./README.md pyproject.toml ./poetry.lock ./
+COPY ./README.md pyproject.toml ./
+# COPY ./README.md pyproject.toml ./poetry.lock ./
 RUN mkdir acapy_agent && touch acapy_agent/__init__.py
 
 ARG all_extras=0
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
