Build insert statement with context's quote style

Author: MoonE

src/Components/IntoKeyword.php

@@ -5,6 +5,7 @@
 namespace PhpMyAdmin\SqlParser\Components;
 
 use PhpMyAdmin\SqlParser\Component;
+use PhpMyAdmin\SqlParser\Context;
 use PhpMyAdmin\SqlParser\Parser;
 use PhpMyAdmin\SqlParser\Token;
 use PhpMyAdmin\SqlParser\TokensList;
@@ -271,7 +272,7 @@ public function parseFileOptions(Parser $parser, TokensList $list, $keyword = 'F
     public static function build($component, array $options = [])
     {
         if ($component->dest instanceof Expression) {
-            $columns = ! empty($component->columns) ? '(`' . implode('`, `', $component->columns) . '`)' : '';
+            $columns = $component->columns ? '(' . implode(', ', Context::escapeAll($component->columns)) . ')' : '';
 
             return $component->dest . $columns;
         }

src/Context.php

@@ -803,7 +803,7 @@ private static function getModeFromString(string $mode): int
     }
 
     /**
-     * Escapes the symbol by adding surrounding backticks.
+     * Escapes the symbol according to the curren sql mode.
      *
      * @param string[]|string $str   the string to be escaped
      * @param string          $quote quote to be used when escaping
@@ -831,6 +831,18 @@ public static function escape($str, $quote = '`')
         return $quote . str_replace($quote, $quote . $quote, $str) . $quote;
     }
 
+    /**
+     * Escapes the symbol according to the curren sql mode.
+     *
+     * @param string[] $strings the string to be escaped
+     *
+     * @return string[]
+     */
+    public static function escapeAll(array $strings): array
+    {
+        return array_map([Context::class, 'escape'], $strings);
+    }
+
     /**
      * Returns char used to quote identifiers based on currently set SQL Mode (ie. standard or ANSI_QUOTES)
      *

tests/Builder/InsertStatementTest.php

@@ -4,64 +4,65 @@
 
 namespace PhpMyAdmin\SqlParser\Tests\Builder;
 
+use Generator;
+use PhpMyAdmin\SqlParser\Context;
 use PhpMyAdmin\SqlParser\Parser;
 use PhpMyAdmin\SqlParser\Tests\TestCase;
 
 class InsertStatementTest extends TestCase
 {
-    public function testBuilder(): void
+    private int $mode;
+
+    public function setUp(): void
     {
-        /* Assertion 1 */
-        $parser = new Parser('INSERT INTO tbl(`col1`, `col2`, `col3`) VALUES (1, "str", 3.14)');
-        $stmt = $parser->statements[0];
-        $this->assertEquals(
-            'INSERT INTO tbl(`col1`, `col2`, `col3`) VALUES (1, "str", 3.14)',
-            $stmt->build()
-        );
+        parent::setUp();
 
-        /* Assertion 2 */
-        /* Reserved keywords (with backquotes as field name) */
-        $parser = new Parser('INSERT INTO tbl(`order`) VALUES (1)');
-        $stmt = $parser->statements[0];
-        $this->assertEquals(
-            'INSERT INTO tbl(`order`) VALUES (1)',
-            $stmt->build()
-        );
+        $this->mode = Context::getMode();
+    }
 
-        /* Assertion 3 */
-        /* INSERT ... SET ... */
-        $parser = new Parser('INSERT INTO tbl SET FOO = 1');
-        $stmt = $parser->statements[0];
-        $this->assertEquals(
-            'INSERT INTO tbl SET FOO = 1',
-            $stmt->build()
-        );
+    protected function tearDown(): void
+    {
+        Context::setMode($this->mode);
 
-        /* Assertion 4 */
-        /* INSERT ... SELECT ... */
-        $parser = new Parser('INSERT INTO tbl SELECT * FROM bar');
-        $stmt = $parser->statements[0];
-        $this->assertEquals(
-            'INSERT INTO tbl SELECT * FROM bar',
-            $stmt->build()
-        );
+        parent::tearDown();
+    }
 
-        /* Assertion 5 */
-        /* INSERT ... ON DUPLICATE KEY UPDATE ... */
-        $parser = new Parser('INSERT INTO tbl SELECT * FROM bar ON DUPLICATE KEY UPDATE baz = 1');
+    /** @dataProvider providerForTestBuilder */
+    public function testBuilder(string $sql): void
+    {
+        $parser = new Parser($sql);
         $stmt = $parser->statements[0];
-        $this->assertEquals(
+        $this->assertEquals($sql, $stmt->build());
+    }
+
+    public function providerForTestBuilder(): Generator
+    {
+        yield 'INSERT ... VALUES ...' => [
+            'INSERT INTO tbl(`col1`, `col2`, `col3`) VALUES (1, "str", 3.14)',
+        ];
+        yield 'Reserved keywords (with backquotes as field name)' => [
+            'INSERT INTO tbl(`order`) VALUES (1)',
+        ];
+        yield 'INSERT ... SET ...' => [
+            'INSERT INTO tbl SET FOO = 1',
+        ];
+        yield 'INSERT ... SELECT ... ' => [
+            'INSERT INTO tbl SELECT * FROM bar',
+        ];
+        yield 'INSERT ... ON DUPLICATE KEY UPDATE ...' => [
             'INSERT INTO tbl SELECT * FROM bar ON DUPLICATE KEY UPDATE baz = 1',
-            $stmt->build()
-        );
+        ];
+        yield 'INSERT [OPTIONS] INTO ...' => [
+            'INSERT DELAYED IGNORE INTO tbl SELECT * FROM bar',
+        ];
+    }
 
-        /* Assertion 6 */
-        /* INSERT [OPTIONS] INTO ... */
-        $parser = new Parser('INSERT DELAYED IGNORE INTO tbl SELECT * FROM bar');
+    public function testBuilderAnsi(): void
+    {
+        Context::setMode(Context::SQL_MODE_ANSI);
+        $sql = "INSERT INTO foo (bar, baz) VALUES ('bar', 'baz')";
+        $parser = new Parser($sql);
         $stmt = $parser->statements[0];
-        $this->assertEquals(
-            'INSERT DELAYED IGNORE INTO tbl SELECT * FROM bar',
-            $stmt->build()
-        );
+        $this->assertEquals('INSERT INTO foo("bar", "baz") VALUES (\'bar\', \'baz\')', $stmt->build());
     }
 }