Search string must be encoded to bytes (#93)

Author: pyoor

src/lithium/interestingness/outputs.py

@@ -75,7 +75,7 @@ def interesting(
         outputs = (run_info.out, run_info.err)
         for data in outputs:
             if (args.regex and re.match(args.search, data, flags=re.MULTILINE)) or (
-                args.search in data
+                args.search.encode("utf-8") in data
             ):
                 LOG.info("[Interesting] Match detected!")
                 return True

tests/test_interestingness.py

@@ -9,10 +9,13 @@
 import sys
 import time
 from pathlib import Path
+from unittest.mock import MagicMock, patch
 
 import pytest
 
 import lithium
+from lithium.interestingness import outputs
+from lithium.interestingness.timed_run import RunData
 
 CAT_CMD = [
     sys.executable,
@@ -228,6 +231,16 @@ def test_outputs_true() -> None:
     assert lith.test_count == 1
 
 
+def test_outputs_in_bytes_true() -> None:
+    """Test that output test properly identifies string in bytes object"""
+    mock_run_data = MagicMock(RunData)
+    mock_run_data.err = b""
+    mock_run_data.out = b"magic bytes"
+    with patch("lithium.interestingness.outputs.timed_run") as mock_timed_run:
+        mock_timed_run.return_value = mock_run_data
+        assert outputs.interesting(["-s", "magic bytes"] + LS_CMD)
+
+
 def test_outputs_false() -> None:
     """interestingness 'outputs' negative test"""
     lith = lithium.Lithium()