unfixed yet

Author: Mrezadwiprasetiawan

.github/workflows/cmake.yaml

@@ -40,7 +40,7 @@ jobs:
           echo "Running prime -s 100"
           ./prime -s 100
           echo "Running prime -l 100"
-          ./prime -l 1k
+          ./prime -l 100
           echo "Running prime -n 104729"
           ./prime -n 104729
           echo "Running prime -i 1m"
@@ -49,3 +49,5 @@ jobs:
           ./fibonacci -l 10
           echo "Running fibonacci -i 100"
           ./fibonacci -i 100
+          echo "Running test_3d"
+          ./test_3d

3D/include/matrix.hxx

@@ -33,7 +33,9 @@ class Mat {
     for (int i = 0; i < N * N; ++i) arr[i] = vals[i];
   }
 
-  std::vector<T> to_vector() const { return std::vector<T>(vals, vals + N * N); }
+  std::vector<T> to_vector() const {
+    return std::vector<T>(vals, vals + N * N);
+  }
 
   void set_elements(T (&v)[N * N]) {
     for (int i = 0; i < N * N; ++i) vals[i] = v[i];
@@ -59,9 +61,7 @@ class Mat {
           vals[row * N + col] = 0;
   }
 
-  void set_element(size_t i, T valsue){
-    vals[i] = valsue;
-  }
+  void set_element(size_t i, T valsue) { vals[i] = valsue; }
 
   template <typename U>
   Mat operator*(U fp) const {
@@ -204,7 +204,7 @@ class Mat {
 
     return Mat(res);
   }
-  const T *data() const { return vals; }
+  const T *data() { return vals; }
 };
 
 // usage Mat3<double> or Mat3<float>
@@ -236,8 +236,9 @@ Mat<T, 4> mat3_to_mat4(const Mat<T, 3> &m) {
   return Mat<T, 4>(res_arr);
 }
 
-// operasi matriks 4×4 * 3×3
-// rubah dulu yang 3×3 ke 4×4 dengan menambahkan komponen w
+/*operasi matriks 4×4 * 3×3
+ * rubah dulu yang 3×3 ke 4×4 dengan menambahkan komponen w
+ */
 template <typename T>
 Mat<T, 4> operator*(const Mat<T, 4> &a, const Mat<T, 3> &b) {
   return a * mat3_to_mat4<T>(b);

3D/include/obj3d.hxx

@@ -12,20 +12,20 @@ class Obj3D {
   Mat<FP, 3> QcurrMat;
   Vec3<FP> pos;
   std::vector<Vec3<FP>> vertices;
-  std::vector<Vec3<I>> face_indices;
-  std::vector<Vec3<FP>> renew_vertices;
+  std::vector<Vec3<I>> faceIndices;
+  std::vector<Vec3<FP>> newVertices;
   std::vector<Vec3<FP>> normals;
 
   // update vertices
   void update_vertices() {
-    for (size_t i = 0; i < face_indices.size(); ++i) {
-      Vec3 f_i = face_indices[i];
+    for (size_t i = 0; i < faceIndices.size(); ++i) {
+      Vec3 f_i = faceIndices[i];
       assert(f_i.x() > 0 && f_i.x() < vertices.size());
       assert(f_i.y() > 0 && f_i.y() < vertices.size());
       assert(f_i.z() > 0 && f_i.z() < vertices.size());
-      renew_vertices.push_back(vertices[f_i.x()]);
-      renew_vertices.push_back(vertices[f_i.y()]);
-      renew_vertices.push_back(vertices[f_i.z()]);
+      newVertices.push_back(vertices[f_i.x()]);
+      newVertices.push_back(vertices[f_i.y()]);
+      newVertices.push_back(vertices[f_i.z()]);
     }
   }
 
@@ -34,8 +34,8 @@ class Obj3D {
    * otomatis memperbarui vertices tapi originalnya tidak dihapus agar lebih
    * mudah diambil nanti
    */
-  Obj3D(std::vector<Vec3<FP>> vertices, std::vector<Vec3<I>> face_indices)
-      : vertices(vertices), face_indices(face_indices) {
+  Obj3D(std::vector<Vec3<FP>> vertices, std::vector<Vec3<I>> faceIndices)
+      : vertices(vertices), faceIndices(faceIndices) {
     update_vertices();
     QcurrMat.set_identity();
     modelMat.set_identity();
@@ -71,24 +71,24 @@ class Obj3D {
     return res;
   }
 
-  std::vector<Vec3<I>> get_face_index() const { return face_indices; }
+  std::vector<Vec3<I>> get_face_index() const { return faceIndices; }
   std::vector<Vec3<FP>> get_default_vertices() const { return vertices; }
   std::vector<Vec3<FP>> get_processed_vertices() const {
-    return renew_vertices;
+    return newVertices;
   }
   // setter
   void update_vertices(std::vector<Vec3<FP>> vertices) {
     this->vertices = vertices;
     update_vertices();
   }
-  void update_face(std::vector<Vec3<FP>> face_indices) {
-    this->face_indices = face_indices;
+  void update_face(std::vector<Vec3<FP>> faceIndices) {
+    this->faceIndices = faceIndices;
     update_vertices();
   }
   void update_face_vertices(std::vector<Vec3<FP>> vertices,
-                            std::vector<Vec3<I>> face_indices) {
+                            std::vector<Vec3<I>> faceIndices) {
     this->vertices = vertices;
-    this->face_indices = face_indices;
+    this->faceIndices = faceIndices;
     update_vertices();
   }
 };

3D/include/vec.hxx

@@ -50,8 +50,6 @@ class Vec {
   VEC_OV_ASSIGNMENT(/);
 #undef VEC_OV_ASSIGNMENT
 
-  // karena SFINAE hanya bisa non error jika di paeameter template
-  // atau di parameter fungsi maka pengecekan diletakan di parametee template
 #define GETTER_XYZ(type, index)         \
   template <typename U = T>             \
   is_type_t<(N >= 3), U> type() const { \