Skip to content

Commit 2110717

Browse files
committed
Unreviewed, suppress wrong threading assertion for InlineCacheHandler
https://bugs.webkit.org/show_bug.cgi?id=278435 rdar://134290611 It gets destroyed in the GC end phase and it gets stale assertion about threading checks. But that assertion is wrong since GC end phase is ensuring that we are not running mutator, so we can safely and correctly derefing this InlineCacheHandler inside it. This is fixing this wrong assertion. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::m_watchpoint): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.h: Canonical link: https://commits.webkit.org/282538@main
1 parent a7cbc19 commit 2110717

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1684,6 +1684,7 @@ InlineCacheHandler::InlineCacheHandler(Ref<InlineCacheHandler>&& previous, Ref<P
16841684
, m_stubRoutine(WTFMove(stubRoutine))
16851685
, m_watchpoint(WTFMove(watchpoint))
16861686
{
1687+
disableThreadingChecks();
16871688
}
16881689

16891690
Ref<InlineCacheHandler> InlineCacheHandler::create(Ref<InlineCacheHandler>&& previous, CodeBlock* codeBlock, StructureStubInfo& stubInfo, Ref<PolymorphicAccessJITStubRoutine>&& stubRoutine, std::unique_ptr<StructureStubInfoClearingWatchpoint>&& watchpoint, unsigned callLinkInfoCount)

Source/JavaScriptCore/bytecode/InlineCacheCompiler.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,9 @@ class InlineCacheHandler final : public RefCounted<InlineCacheHandler>, public T
247247
private:
248248
InlineCacheHandler()
249249
: Base(0)
250-
{ }
250+
{
251+
disableThreadingChecks();
252+
}
251253

252254
InlineCacheHandler(Ref<InlineCacheHandler>&&, Ref<PolymorphicAccessJITStubRoutine>&&, std::unique_ptr<StructureStubInfoClearingWatchpoint>&&, unsigned callLinkInfoCount, CacheType);
253255

0 commit comments

Comments
 (0)