Eliminate virtual function call in Node::pseudoId()

https://bugs.webkit.org/show_bug.cgi?id=292099

Reviewed by Anne van Kesteren.

Devirtualize Node::pseudoId() by storing a bit for IsPseudoElement.

* Source/WebCore/dom/Node.h:
(WebCore::Node::isPseudoElement const):
(WebCore::Node::isBeforePseudoElement const): Moved to NodeInlines.h
(WebCore::Node::isAfterPseudoElement const): Ditto.
(WebCore::Node::pseudoId const): Ditto.
(WebCore::Node::customPseudoId const): Deleted.
* Source/WebCore/dom/NodeInlines.h:
(WebCore::Node::isBeforePseudoElement const):
(WebCore::Node::isAfterPseudoElement const):
(WebCore::Node::pseudoId const):
* Source/WebCore/dom/PseudoElement.cpp:
(WebCore::PseudoElement::PseudoElement):
* Source/WebCore/dom/PseudoElement.h:
* Source/WebCore/style/Styleable.h:

Canonical link: https://commits.webkit.org/294168@main

Author: rniwa

Source/WebCore/dom/Node.h

@@ -234,10 +234,10 @@ class Node : public EventTarget, public CanMakeCheckedPtr<Node> {
 
     bool isFormControlElement() const { return hasTypeFlag(TypeFlag::IsFormControlElement); }
 
-    bool isPseudoElement() const { return pseudoId() != PseudoId::None; }
-    bool isBeforePseudoElement() const { return pseudoId() == PseudoId::Before; }
-    bool isAfterPseudoElement() const { return pseudoId() == PseudoId::After; }
-    PseudoId pseudoId() const { return (isElementNode() && hasCustomStyleResolveCallbacks()) ? customPseudoId() : PseudoId::None; }
+    bool isPseudoElement() const { return hasStateFlag(StateFlag::IsPseudoElement); }
+    inline bool isBeforePseudoElement() const;
+    inline bool isAfterPseudoElement() const;
+    inline PseudoId pseudoId() const;
 
 #if ENABLE(VIDEO)
     virtual bool isWebVTTElement() const { return false; }
@@ -645,8 +645,9 @@ class Node : public EventTarget, public CanMakeCheckedPtr<Node> {
 #endif
         ContainsSelectionEndPoint = 1 << 11,
         IsSpecialInternalNode = 1 << 12, // DocumentFragment node for innerHTML/outerHTML or EditingText node.
+        IsPseudoElement = 1 << 13, // FIXME: This belongs to TypeFlag.
 
-        // 3 bits free.
+        // 2 bits free.
     };
 
     enum class ElementStateFlag : uint16_t {
@@ -778,12 +779,6 @@ class Node : public EventTarget, public CanMakeCheckedPtr<Node> {
     ExceptionOr<NodeVector> convertNodesOrStringsIntoNodeVector(FixedVector<NodeOrString>&&);
 
 private:
-    virtual PseudoId customPseudoId() const
-    {
-        ASSERT(hasCustomStyleResolveCallbacks());
-        return PseudoId::None;
-    }
-
     WEBCORE_EXPORT void removedLastRef();
 
     void refEventTarget() final;

Source/WebCore/dom/NodeInlines.h

@@ -24,6 +24,7 @@
 #include "Document.h"
 #include "Element.h"
 #include "Node.h"
+#include "PseudoElement.h"
 #include "WebCoreOpaqueRoot.h"
 
 namespace WebCore {
@@ -70,6 +71,23 @@ inline RefPtr<Element> Node::protectedParentElement() const
     return parentElement();
 }
 
+bool Node::isBeforePseudoElement() const
+{
+    return pseudoId() == PseudoId::Before;
+}
+
+bool Node::isAfterPseudoElement() const
+{
+    return pseudoId() == PseudoId::After;
+}
+
+PseudoId Node::pseudoId() const
+{
+    if (auto* pseudoElement = dynamicDowncast<PseudoElement>(*this))
+        return pseudoElement->pseudoId();
+    return PseudoId::None;
+}
+
 inline void Node::setTabIndexState(TabIndexState state)
 {
     auto bitfields = rareDataBitfields();

Source/WebCore/dom/PseudoElement.cpp

@@ -54,6 +54,7 @@ PseudoElement::PseudoElement(Element& host, PseudoId pseudoId)
     , m_pseudoId(pseudoId)
 {
     setEventTargetFlag(EventTargetFlag::IsConnected);
+    setStateFlag(StateFlag::IsPseudoElement);
     ASSERT(pseudoId == PseudoId::Before || pseudoId == PseudoId::After);
 }
 

Source/WebCore/dom/PseudoElement.h

@@ -41,6 +41,8 @@ class PseudoElement final : public Element {
     Element* hostElement() const { return m_hostElement.get(); }
     void clearHostElement();
 
+    PseudoId pseudoId() const { return m_pseudoId; }
+
     bool rendererIsNeeded(const RenderStyle&) override;
 
     bool canStartSelection() const override { return false; }
@@ -49,8 +51,6 @@ class PseudoElement final : public Element {
 private:
     PseudoElement(Element&, PseudoId);
 
-    PseudoId customPseudoId() const override { return m_pseudoId; }
-
     WeakPtr<Element, WeakPtrImplWithEventTargetData> m_hostElement;
     PseudoId m_pseudoId;
 };

Source/WebCore/style/Styleable.h

@@ -26,6 +26,7 @@
 #pragma once
 
 #include "Element.h"
+#include "NodeInlines.h"
 #include "PseudoElement.h"
 #include "PseudoElementIdentifier.h"
 #include "RenderStyleConstants.h"