Conversation
|
cc @krisgesling would you review this please? |
|
I built windows artifacts as an example in: |
krisgesling
left a comment
krisgesling
left a comment
There was a problem hiding this comment.
Wow congrats!!
I'll need to get a Windows install setup to test it properly but I think it's a good move to keep the batch scripts small and do as much as possible in Python.
A few quick things based on a first glance, and would be great to add docstrings to help document the various functions, their arguments and return values. See #6 in this list from our contributing guide
win-package.py
Outdated
| except FileNotFoundError: | ||
| return False | ||
|
|
||
| def package_scripts(tar_prefix, combined_folder, scripts, train_libs): |
There was a problem hiding this comment.
it looks like it could be useful to split this function up a little bit for readability
There was a problem hiding this comment.
Ok, can do.
Basically it's a port of build.sh, but why not :)
| ] | ||
| hidden_imports += ['h5py'] | ||
|
|
||
| datas = collect_data_files('astor', subdir=None, include_py_files=False) |
There was a problem hiding this comment.
What does this return? A list of data files?
There was a problem hiding this comment.
The astor lib uses an internal file called VERSION.l, which pyinstaller does not include by default.
Pyinstaller does allow you to specify data files which should be bundled along.
See
https://pyinstaller.readthedocs.io/en/stable/spec-files.html#adding-data-files
The function returns a list of tuples where the first is a file name and the second is the folder to insert it to.
Here it will collect all yhe non python files in the root directory of astor.
If that's preferable I think I can specify the exact file instead as shown here:
https://pyinstaller.readthedocs.io/en/stable/spec-files.html#using-data-files-from-a-module
krisgesling
added
enhancement
CLA: Yes
|
I did as you asked:) |
|
Oh, apparently even though precise-engine works perfectly, the scripts used for training do not. |
2 participants
Add support for windows.
Build requirements:
Build instructions:
Pretty simple, setup.bat and build.bat are the windows equivalent of setup.sh/build.sh respectively.
Because batch is a nightmare, setup.bat uses a script called win-package.py.
Related: #163