Fixed and added precise choose script#25
Open
mikhaildmitrienko wants to merge 6 commits intoMycroftAI:devfrom
Open
Fixed and added precise choose script#25mikhaildmitrienko wants to merge 6 commits intoMycroftAI:devfrom
mikhaildmitrienko wants to merge 6 commits intoMycroftAI:devfrom
Conversation
Merge changes from mycroft-precise
Changed the maximum possible amount of units for the optimization to return to 70 units.
removed a redundant line of code. print("False positive: ", false_positives * 100, "%") is already printed so print(false_positives) isn't needed.
Changed spacing between file id and wakeword status from four spaces to a tab so that precise can read the newly created tags
| print('False negative ', (i + 1), ' of ', (len(false_negatives_array)) + 1) | ||
| user_input = input('Enter y if wakeword, enter n for not wakeword \n') | ||
| time.sleep(5) | ||
| false_negatives_array[i] = false_negatives_array[i].lstrip('/Users/madmitrienko/wakewords/files/') |
Contributor
There was a problem hiding this comment.
Need to generalize this and pass it to the script as a variable or an environmental setting.
chrisveilleux
added a commit
that referenced
this pull request
Apr 14, 2020
|
Hello, Since I need that project, I decided to fork and advance. Sorry for the inconvenience but it can be reversed if Mycroft wants of course). You will find your PR already integrated to the fork here. Again, sorry for the inconvenient. I created a thread on Mycroft community forum to discuss this. @joshua-montgomery is this still relevant ? It needs some works anyway for it to be integrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug that prevented tag files written by precise-choose from being read and added precise choose as executable.