"CMR STAC in R" Notebook Updates #389
Conversation
|
Thanks so much @jules32! Just to make sure, is |
|
Yes it is, thanks! |
|
Hi @ateucher! Any feedback or updates on this PR yet? 🙂 |
|
Hi @smk0033 - so sorry for the delay. I will be able to look at this early next week! |
|
No worries, just wanted to check in - thanks! |
There was a problem hiding this comment.
This is great @smk0033, thank you so much! I think it shows the workflow very well.
For context for the user, do you think it's worth explaining when/why a user would use STAC vs Earthdata Search?
From my understanding, since STAC is a standard protocol and there are many other STAC catalogues out there (e.g., ESA STAC), using it for NASA data would be the same as for other catalogues, so a user doesn't need to learn different search methods.
I've added some suggestions (mostly technical wrt R syntax), as well as a few content thoughts/suggestions.
Co-authored-by: Andy Teucher <andy.teucher@gmail.com>
|
Thank you for the thorough review! I've made the requested changes |
|
Thanks @smk0033 this is looking great now! For the author information at the bottom, I think you could probably replace the contact info with yours (and/or whomever's is the most appropriate, and leave just the note about the original material being by Mahsa and Aaron (PL DAAC), without their contact info. |
There was a problem hiding this comment.
I think this is great @smk0033!
I think the next step is to move it to the appropriate place (Tutorials I think?), render it and add computation outputs to _freeze before merging. That part can be a bit tedious / lead to merge conflicts... I'm happy to do it if you'd like to leave it here? Or also happy to help you work through the process...
@jules32 do you think this best belongs in "Tutorials" vs "How do I...?". I don't think we currently have good guidance on those?
|
On second thought, maybe this is more of a how-to based on this description. |
|
Let me check with the MAAP Team on who/what to include in the contact section! I'll let you know as soon as that's updated, and then I'll pass merging along to you |
|
@ateucher I've updated the last section! |
|
@smk0033 Can you please see if there is a tickbox on the right side of this page that says "Allow edits from maintainers", or something similar to that? That way I can push to this PR to finish things off before merging. Thanks! |
|
@ateucher that option seems to be missing |
|
/deploy-preview |
|
/deploy-preview |
There was a problem hiding this comment.
@smk0033 I think this is ready to merge now, but I made a few other changes so wanted to give you a chance to have a look:
- I moved it to
how-tos/find-data - I added a bit to the preamble, and also added a short "Why STAC" section.
You can see a rendered preview of the page here: https://deploy-preview--openscapes-org-preview.netlify.app/how-tos/find-data/cmr-stac-search.
Let me know what you think!
|
Thanks @ateucher! I think the preview looks good! |
|
Awesome, thanks for all your work on this! I'll merge, then you can remove me as a collaborator from your repo if you'd like. |
3 participants
The NASA IMPACT MAAP Team has updated the in development tutorial "CMR STAC in R". Updates include:
earthdataloginpackage to list NASA STACsrstacpackage instead ofhttrI was not quite sure how to handle the author attributions at the end since we updated the original tutorial, so guidance there would especially be appreciated.
Thank you all for letting us collaborate and work on this! Please feel free to leave any feedback.