Update fe forcing #340
Open
Update fe forcing #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just fesedflux and feventflux, updates to MARBL from UCI now add an fesedfluxred forcing field.
Added optional argument num_pass to MOM_initialize_tracer_from_Z(), which then gets passed down to horiz_interp_and_extrap_tracer() eventually is passed to fill_miss_2d() [where the optional argument is already part of the API but is never used]. I tested this updated by setting num_pass=0 for the MARBL tracers and verifying that the smoothing step was not run, but that was just a test to see if the smoothing was responsible for some unexpected tracer values in the MARBL initial conditions -- in general, we do want to smooth the MARBL tracers after they are initialized.
There was an issue where smoothing the MARBL tracer initial conditions led to some inconsistent tracer values for tracers associated with MARBL's autotrophs. For each autotroph, if any tracer (C, N, P, etc) is 0 we want all of that autotroph's tracers to be 0... but the smoothing algorithm in MOM_initialize_tracer_from_Z() would sometimes leave one tracer at 0 but introduce a nonzero value in a different tracer at the same location. The subroutine on the MARBL interface enforces this consistency. This function is called whenever any MARBL tracer is initialized with MOM_initialize_tracer_from_Z(); if all the tracers are read in from a restart file then this subroutine is skipped. If this function is called, it is noted in the log with the following message: Enforcing consistency across autotroph tracer initial conditions
Added autotroph_tracer_consistency_enforce() to the dummy MARBL interface so MARBL_tracers.F90 can still be built without MARBL
MARBL_tracers_stock() was writing a list of all tracers from all processors, filling up cesm.log unnecessarily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
marbl-ecosys/MARBL#464 updates MARBL's iron sediment forcing scheme, which will change what forcing fields MOM6 needs to provide to MARBL