Code Valor: high-impact violation in ccpp_prebuild code generator

[climbfuji]

Description

Code Valor is being run on the ccpp-prebuild code generator at NRL as we prepare for transition to operations. It found one high-impact violation that must be addressed, namely the use of shell=True in a subprocess.Popen call in prebuild's scripts/common.py.

It turns out that the function that uses it (execute) is only used in one place (when cleaning files) and this can perfectly be substituted with Python os.remove.

Steps to Reproduce

Not possible unless you have access to Code Valor and the NRL configuration for it.

Additional Context

Code Valor high-impact violations must be addressed before transitioning code to operations

Output

n/a

[mkavulich]

@climbfuji I'm not sure why this issue didn't close automatically with the PR merge, I assume this issue is complete?

[climbfuji]

Because we merge into develop instead of the default branch :-(