Use of w3emc in GFS_time_vary_pre is not safe - no protection against argument mismatches

[climbfuji]

Description

The way w3emc is used in GFS_time_vary_pre is not safe, since there is no protection against argument mismatches in case the wrong version of the library (e.g., _4 instead of _d) is used. This came up during the debugging of a w3emc build issue with Intel oneAPI ifx.

A detailed description can be found here: JCSDA/spack-stack#1716

The issue also provides a code snippet that protects against using a wrong kind for the integer and real arguments in the w3difdat routines.

Steps to Reproduce

See JCSDA/spack-stack#1716

Additional Context

See JCSDA/spack-stack#1716

Output

See JCSDA/spack-stack#1716

[climbfuji]

@grantfirl I lost track, has this been fixed (merged) already or is your PR for it still open?

[grantfirl]

@grantfirl I lost track, has this been fixed (merged) already or is your PR for it still open?

Merged into NCAR/main. The PR into ufs/dev is ufs-community#309 and is still open.

[climbfuji]

Thanks! I will close this as completed.