GNU -Wall Warning Reduction, Part 1 #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrasmussen
requested review from
wd20xw,
grantfirl,
rhaesung,
Qingfu-Liu,
dustinswales,
tanyasmirnova,
barlage,
cenlinhe,
HelinWei-NOAA,
SamuelTrahanNOAA,
joeolson42,
RuiyuSun,
mdtoyNOAA,
haiqinli and
mzhangw
as code owners
This was referenced Dec 12, 2024
tanyasmirnova
approved these changes
Dec 12, 2024
climbfuji
approved these changes
Dec 12, 2024
Qingfu-Liu
approved these changes
Feb 27, 2025
… redefinition warnings
…must be integer' message by calling nint intrinsic. Copying the other do loops
…nt at (1) [-Wampersand]'
…ed at (1) not set [-Wreturn-type]"
scrasmussen
force-pushed
the
gnu-wall-warning-reduction-part1
branch
from
a0a909f to
148b322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES: This is subset of commits from PR #1049 and PR #1048. I've combined them into one PR so I only have to do one that targets
ufs-community:ufs/devfor now.The warning report was made using create_warning_report.sh from the warning-report branch of my SCM fork. Users will need to edit
scm/src/CMakeLists.txtso GNU'sCMAKE_Fortran_FLAGS_DEBUGhas-Wallat the end to get all the warnings.NOTE: this PR removes 219 warnings. Ampersand and tab warnings will be reduced with SCM PR#425
ISSUES: related to Issues #495